Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated form description field. added custom logic and styling #257

Merged
merged 19 commits into from
May 8, 2024

Conversation

kildre
Copy link
Contributor

@kildre kildre commented May 1, 2024

Updated the Description field on form to only allow 200 characters, but allow user to paste/enter more characters.

Reference Issues or PRs

https://gitlab.jatic.net/jatic/team-metrostar/t-e-platform/-/issues/523

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Documentation

Access-centered content checklist

Text styling

  • The content is written with plain language (where relevant).
  • If there are headers, they use the proper header tags (with only one level-one header: H1 or # in markdown).
  • All links describe where they link to (for example, check the Nebari website).
  • This content adheres to the Nebari style guides.

Non-text content

  • All content is represented as text (for example, images need alt text, and videos need captions or descriptive transcripts).
  • If there are emojis, there are not more than three in a row.
  • Don't use flashing GIFs or videos.
  • If the content were to be read as plain text, it still makes sense, and no information is missing.

Any other comments?

DESCRIPTION

Copy link

vercel bot commented May 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
jhub-apps ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2024 4:11pm
jhub-apps-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2024 4:11pm

@aktech
Copy link
Member

aktech commented May 6, 2024

@kildre can you merge main and see if that fixes CI issues? I just merged a PR for the same.

@kildre
Copy link
Contributor Author

kildre commented May 6, 2024

@aktech I'll do that.

@aktech
Copy link
Member

aktech commented May 6, 2024

The test failures are genuine failures. The JupyterHub doesn't loads:

Screenshot 2024-05-06 at 3 30 05 pm

Console errors (Its unable to find static files, as you have moved them):

Screenshot 2024-05-06 at 3 29 49 pm

…wrap to break continuous string of text, new static css
Copy link
Collaborator

@jbouder jbouder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Need to update a few things.

ui/src/components/app-form/app-form.tsx Outdated Show resolved Hide resolved
ui/src/components/app-form/app-form.tsx Outdated Show resolved Hide resolved
ui/src/components/app-form/app-form.tsx Outdated Show resolved Hide resolved
Copy link
Contributor Author

@kildre kildre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made updates

Copy link
Collaborator

@jbouder jbouder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@jbouder jbouder merged commit fd66e4b into nebari-dev:main May 8, 2024
25 checks passed
@jbouder jbouder deleted the ui-char-count-523 branch May 8, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants