-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Act as user instead of service #278
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a very nice solution. I wonder what will be the overhead of using temporary tokens for each operations (after all they are added to database and commits are not free) but I suspect that this will be rather cheap.
Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com>
Yeah, ideally I would have preferred caching them and delete them after some delay, but didn't wanted to complicate logic until we know it's a problem in practice. |
Reference Issues or PRs
This is so that we have better control of fine-grained permissions on what a user can and cannot do instead of delegating these tasks to service, which has more permissions than user. Previously we were doing all the operations as service, this PR is undoing that.
What does this implement/fix?
Put a
x
in the boxes that applyTesting
Documentation
Access-centered content checklist
Text styling
H1
or#
in markdown).Non-text content
Any other comments?