Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixit ticket 530 #288

Merged
merged 6 commits into from
May 23, 2024
Merged

Fixit ticket 530 #288

merged 6 commits into from
May 23, 2024

Conversation

kildre
Copy link
Contributor

@kildre kildre commented May 22, 2024

Made updates to the UI

Reference Issues or PRs

Added loading state to creat app button, updates to the chips size, tweaks ot the text fields

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • [x ] New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Documentation

Access-centered content checklist

Text styling

  • The content is written with plain language (where relevant).
  • If there are headers, they use the proper header tags (with only one level-one header: H1 or # in markdown).
  • All links describe where they link to (for example, check the Nebari website).
  • This content adheres to the Nebari style guides.

Non-text content

  • All content is represented as text (for example, images need alt text, and videos need captions or descriptive transcripts).
  • If there are emojis, there are not more than three in a row.
  • Don't use flashing GIFs or videos.
  • If the content were to be read as plain text, it still makes sense, and no information is missing.

Any other comments?

image

removed-horizontal-separators

medium_chips

Copy link

vercel bot commented May 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
jhub-apps ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 23, 2024 3:33pm
jhub-apps-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 23, 2024 3:33pm

Copy link
Collaborator

@jbouder jbouder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few changes. Plus seeing some formatting issues when loading the app
Screenshot 2024-05-22 at 4 13 01 PM

ui/package.json Show resolved Hide resolved
ui/src/components/app-card/app-card.css Outdated Show resolved Hide resolved
ui/src/components/app-card/app-card.css Outdated Show resolved Hide resolved
ui/src/components/app-card/app-card.tsx Show resolved Hide resolved
ui/src/pages/server-types/server-types.css Outdated Show resolved Hide resolved
@kildre
Copy link
Contributor Author

kildre commented May 23, 2024

A few changes. Plus seeing some formatting issues when loading the app Screenshot 2024-05-22 at 4 13 01 PM

Made updates, alignment back to way it should be.

Copy link
Collaborator

@jbouder jbouder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants