-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add infrastructure docs and diagrams #307
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This is a first pass on the writing, I still need to update the bottom part as I think its confusing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@viniciusdc This covers a lot of really great information! I left a few suggestions on content and also did a grammatical review. Thanks for opening this!
Co-authored-by: Kim Pevey <kcpevey@quansight.com>
@viniciusdc is this ready for review again? |
I am just refactoring that last part, will ping you shortly |
sorry for the delay here @kcpevey, I finished my updates on this, its now ready for a final review. I am happy with how the last sections ended up now :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just had some minor grammatical updates. Feel free to fix if you agree and merge :)
### How does all Work Together? | ||
|
||
As an example, the diagram below illustrates the interaction between the two given | ||
proxies (http--jupyter-server-proxy or http--jhub-single-native), in a kubernetes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
proxies (http--jupyter-server-proxy or http--jhub-single-native), in a kubernetes | |
proxies (`http--jupyter-server-proxy` or `http--jhub-single-native`), in a Kubernetes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to double check - those are supposed to be double dashes, right? e.g. http--
Co-authored-by: Kim Pevey <kcpevey@quansight.com>
Reference Issues or PRs
closes #255
What does this implement/fix?
Put a
x
in the boxes that applyTesting
Documentation
Access-centered content checklist
Text styling
H1
or#
in markdown).Non-text content
Any other comments?