Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Home page updates #311

Merged
merged 16 commits into from
May 31, 2024
Merged

Home page updates #311

merged 16 commits into from
May 31, 2024

Conversation

kildre
Copy link
Contributor

@kildre kildre commented May 29, 2024

Updates to the home page, mainly stylistic changes, but also text updates and iconography.

Reference Issues or PRs

https://gitlab.jatic.net/jatic/team-metrostar/t-e-platform/-/issues/595

This update addresses the issues in the attached ticket.

What does this implement/fix?

This implementation fixes stylistic and design issues
Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Documentation

Access-centered content checklist

Text styling

  • The content is written with plain language (where relevant).
  • If there are headers, they use the proper header tags (with only one level-one header: H1 or # in markdown).
  • All links describe where they link to (for example, check the Nebari website).
  • This content adheres to the Nebari style guides.

Non-text content

  • All content is represented as text (for example, images need alt text, and videos need captions or descriptive transcripts).
  • If there are emojis, there are not more than three in a row.
  • Don't use flashing GIFs or videos.
  • If the content were to be read as plain text, it still makes sense, and no information is missing.

Any other comments?

Copy link

vercel bot commented May 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
jhub-apps ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 31, 2024 8:19pm
jhub-apps-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 31, 2024 8:19pm

Copy link
Collaborator

@jbouder jbouder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code-wise looks great, just 1 thing to cleanup. Also, please include the following in this PR:

  1. Fix the header opacity
  2. Fix the row spacing between App rows
  3. Ensure the home navigation button can be themed

ui/src/components/app-card/app-card.tsx Outdated Show resolved Hide resolved
@kildre
Copy link
Contributor Author

kildre commented May 31, 2024

Code-wise looks great, just 1 thing to cleanup. Also, please include the following in this PR:

  1. Fix the header opacity
  2. Fix the row spacing between App rows
  3. Ensure the home navigation button can be themed

√, √, √

Copy link
Collaborator

@jbouder jbouder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@jbouder jbouder merged commit 63100de into nebari-dev:main May 31, 2024
25 checks passed
@jbouder jbouder deleted the home-updates-595 branch May 31, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants