Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase UI Test Coverage #360

Merged
merged 11 commits into from
Jun 28, 2024
Merged

Conversation

jbouder
Copy link
Collaborator

@jbouder jbouder commented Jun 27, 2024

This PR is to perform both cleanup of unit tests as well as to increase coverage where possible.

Reference Issues or PRs

N/A

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Screenshots

Screenshot 2024-06-27 at 3 26 25 PM

Any other comments?

  • Fixed axios import on unit test
  • Fixed unit test console error
  • Disabled react-query retries on all applicable unit tests
  • Code refactoring to remove unnecessary complexities
  • Add and update unit tests for better coverage

Copy link

vercel bot commented Jun 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
jhub-apps ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 27, 2024 7:27pm
jhub-apps-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 27, 2024 7:27pm

Copy link
Contributor

@kildre kildre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Great work Johnny!

@jbouder jbouder merged commit 9335283 into nebari-dev:main Jun 28, 2024
25 checks passed
@jbouder jbouder deleted the increase-coverage branch June 28, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants