-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
App theme updates #382
App theme updates #382
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition to the comments, a few other things:
- Remove the CDAO logo
- These changes do no provide a mechanism to override the header colors based on what is provided as a config. You'll need to update this file to handle those:
jhub_apps/static/templates/style.css
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition to the comments:
- Still need to remove the CDAO logo
- The css provided in the style.css overrides the default JupyterHub header styling, but still doesn't override the MUI header styling. Need to address that.
- I can't seem to test your changes locally. I'm not seeing updates applied to JupyterHub, need to troubleshoot that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Added updates to the Nebari theme. Amending colors to use themeing colors and configuartion. Updated logo to a CDAO | Nebari logo
Reference Issues or PRs
https://gitlab.jatic.net/jatic/team-metrostar/t-e-platform/-/issues/669
What does this implement/fix?
Put a
x
in the boxes that applyTesting
Documentation
Access-centered content checklist
Text styling
H1
or#
in markdown).Non-text content
Any other comments?
<img width="1477" alt="image" src="https://github.com/user-attachments/assets/fd8050ee-38c8-442a-97b7-