Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App theme updates #382

Merged
merged 19 commits into from
Jul 12, 2024
Merged

App theme updates #382

merged 19 commits into from
Jul 12, 2024

Conversation

kildre
Copy link
Contributor

@kildre kildre commented Jul 9, 2024

Added updates to the Nebari theme. Amending colors to use themeing colors and configuartion. Updated logo to a CDAO | Nebari logo

Reference Issues or PRs

https://gitlab.jatic.net/jatic/team-metrostar/t-e-platform/-/issues/669

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • [x ] New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • [x ] Code style update (formatting, renaming)
  • [ x] Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • [ x] Did you test the pull request locally?
  • Did you add new tests?

Documentation

Access-centered content checklist

Text styling

  • The content is written with plain language (where relevant).
  • If there are headers, they use the proper header tags (with only one level-one header: H1 or # in markdown).
  • All links describe where they link to (for example, check the Nebari website).
  • This content adheres to the Nebari style guides.

Non-text content

  • All content is represented as text (for example, images need alt text, and videos need captions or descriptive transcripts).
  • If there are emojis, there are not more than three in a row.
  • Don't use flashing GIFs or videos.
  • If the content were to be read as plain text, it still makes sense, and no information is missing.

Any other comments?

image
image

<img width="1477" alt="image" src="https://github.com/user-attachments/assets/fd8050ee-38c8-442a-97b7-
image
image

Copy link

vercel bot commented Jul 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
jhub-apps ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 11, 2024 9:11pm
jhub-apps-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 11, 2024 9:11pm

Copy link
Collaborator

@jbouder jbouder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to the comments, a few other things:

  1. Remove the CDAO logo
  2. These changes do no provide a mechanism to override the header colors based on what is provided as a config. You'll need to update this file to handle those: jhub_apps/static/templates/style.css

jhub_apps/templates/style.css Outdated Show resolved Hide resolved
jhub_apps/templates/style.css Outdated Show resolved Hide resolved
jhub_apps/themes/__init__.py Outdated Show resolved Hide resolved
ui/src/components/navigation/navigation.tsx Outdated Show resolved Hide resolved
Copy link
Collaborator

@jbouder jbouder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to the comments:

  • Still need to remove the CDAO logo
  • The css provided in the style.css overrides the default JupyterHub header styling, but still doesn't override the MUI header styling. Need to address that.
  • I can't seem to test your changes locally. I'm not seeing updates applied to JupyterHub, need to troubleshoot that

jhub_apps/templates/style.css Show resolved Hide resolved
jhub_apps/templates/style.css Outdated Show resolved Hide resolved
jhub_apps/themes/__init__.py Show resolved Hide resolved
jhub_apps/themes/__init__.py Outdated Show resolved Hide resolved
jhub_apps/themes/__init__.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@jbouder jbouder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@jbouder jbouder merged commit 8035cfe into nebari-dev:main Jul 12, 2024
25 checks passed
@jbouder jbouder deleted the app-theme branch July 12, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants