Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI Dependency Review #430

Merged
merged 1 commit into from
Aug 1, 2024
Merged

UI Dependency Review #430

merged 1 commit into from
Aug 1, 2024

Conversation

jbouder
Copy link
Collaborator

@jbouder jbouder commented Aug 1, 2024

Reference Issues or PRs

N/A

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

  • Cleanup dependencies

@vercel Vercel
Copy link

vercel bot commented Aug 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
jhub-apps ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 1, 2024 2:37pm
jhub-apps-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 1, 2024 2:37pm

aktech
aktech approved these changes Aug 1, 2024
View reviewed changes
Copy link
Member

@aktech aktech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, everything works fine.

@aktech aktech merged commit 657f7c8 into main Aug 1, 2024
25 checks passed
@jbouder jbouder deleted the ui-dep-review branch August 1, 2024 14:54
kildre
kildre reviewed Aug 1, 2024
View reviewed changes
Copy link
Contributor

@kildre kildre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kildre kildre kildre left review comments

@aktech aktech aktech approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jbouder @kildre @aktech