Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to deploy #468

Merged
merged 2 commits into from
Aug 19, 2024
Merged

Update to deploy #468

merged 2 commits into from
Aug 19, 2024

Conversation

kildre
Copy link
Contributor

@kildre kildre commented Aug 19, 2024

Updated the text "Create" to "Deploy" and "creating" to "deploying"

Reference Issues or PRs

https://gitlab.jatic.net/jatic/team-metrostar/t-e-platform/-/issues/731

What does this implement/fix?

Fixes the copy of the app to better align with what it's doing.
Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • [ X] Documentation Update
  • [X ] Code style update (formatting, renaming)
  • [ X] Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • [ X] Did you test the pull request locally?
  • Did you add new tests?

Documentation

Access-centered content checklist

Text styling

  • [ X] The content is written with plain language (where relevant).
  • [ X] If there are headers, they use the proper header tags (with only one level-one header: H1 or # in markdown).
  • All links describe where they link to (for example, check the Nebari website).
  • [ X] This content adheres to the Nebari style guides.

Non-text content

  • All content is represented as text (for example, images need alt text, and videos need captions or descriptive transcripts).
  • If there are emojis, there are not more than three in a row.
  • Don't use flashing GIFs or videos.
  • If the content were to be read as plain text, it still makes sense, and no information is missing.

Any other comments?

image

Copy link

vercel bot commented Aug 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
jhub-apps ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 19, 2024 7:42pm
jhub-apps-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 19, 2024 7:42pm

@jbouder jbouder merged commit f6c5c7d into nebari-dev:main Aug 19, 2024
25 checks passed
@jbouder jbouder deleted the update-to-deploy branch August 19, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants