-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename jhub-apps access_token
cookie to be explicit
#474
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
e0333f3
to
811d209
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really good, thank you! Just one question: do we need to keep reading the old cookie for one release cycle just in case to reduce disruption to existing users?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Amit! This cost me quite some time this morning until you realized that access_token
was not coming from JupyterHub, but rather from here.
d1eda4b
to
0a40f05
Compare
Reference Issues or PRs
At the moment the name of the cookie is
access_token
, which is a very generic name. It would be better to prefix it with the app it belongs to, so as to avoid confusion while development.What does this implement/fix?
Put a
x
in the boxes that applyTesting
Documentation
Access-centered content checklist
Text styling
H1
or#
in markdown).Non-text content
Any other comments?