Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin jupyterlab version #186

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Pin jupyterlab version #186

merged 1 commit into from
Oct 31, 2024

Conversation

marcelovilla
Copy link
Member

Reference Issues or PRs

What does this implement/fix?

Given that Jupyterlab 4.3 was recently released, and that it could have side-effects on existing extensions, we're pinning jupyterlab to 4.2.5, the version we were using in the latest release of the docker images. This will allow us to release a hotfix for Nebari 2024.9.1 without worrying about other things potentially breaking.

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Documentation

Access-centered content checklist

Text styling

  • The content is written with plain language (where relevant).
  • If there are headers, they use the proper header tags (with only one level-one header: H1 or # in markdown).
  • All links describe where they link to (for example, check the Nebari website).
  • This content adheres to the Nebari style guides.

Non-text content

  • All content is represented as text (for example, images need alt text, and videos need captions or descriptive transcripts).
  • If there are emojis, there are not more than three in a row.
  • Don't use flashing GIFs or videos.
  • If the content were to be read as plain text, it still makes sense, and no information is missing.

Any other comments?

Copy link
Contributor

@viniciusdc viniciusdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @marcelovilla

@viniciusdc viniciusdc merged commit 951a6d2 into main Oct 31, 2024
11 checks passed
@viniciusdc viniciusdc deleted the pin-jupyterlab branch October 31, 2024 16:45
viniciusdc pushed a commit that referenced this pull request Nov 1, 2024
viniciusdc pushed a commit that referenced this pull request Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants