Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add idle-culling docs #297

Merged
merged 8 commits into from
May 1, 2023
Merged

Add idle-culling docs #297

merged 8 commits into from
May 1, 2023

Conversation

viniciusdc
Copy link
Contributor

Reference Issues or PRs

closes #296

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Documentation

Check the linked issue.

Access-centered content checklist

Text styling

  • The content is written with plain language (where relevant).
  • If there are headers, they use the proper header tags (with only one level-one header: H1 or # in markdown).
  • All links describe where they link to (for example, check the Nebari website).
  • This content adheres to the Nebari style guides.

Non-text content

  • All content is represented as text (for example, images need alt text, and videos need captions or descriptive transcripts).
  • If there are emojis, there are not more than three in a row.
  • Don't use flashing GIFs or videos.
  • If the content were to be read as plain text, it still makes sense, and no information is missing.

Any other comments?

@netlify
Copy link

netlify bot commented Apr 6, 2023

Deploy Preview for nebari-docs ready!

Name Link
🔨 Latest commit 2576668
🔍 Latest deploy log https://app.netlify.com/sites/nebari-docs/deploys/643844795d397e0008207217
😎 Deploy Preview https://deploy-preview-297--nebari-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

docs/docs/how-tos/nebari-idle-culler.md Show resolved Hide resolved
@pavithraes pavithraes added type: enhancement 💅🏼 New feature or request status: in progress 🏗 This task is currently being worked on labels Apr 7, 2023
viniciusdc and others added 2 commits April 13, 2023 13:51
Co-authored-by: Pavithra Eswaramoorthy <pavithraes@outlook.com>
@viniciusdc viniciusdc requested a review from pavithraes April 13, 2023 18:05
@pavithraes pavithraes requested a review from iameskild April 24, 2023 15:45
@iameskild
Copy link
Member

iameskild commented Apr 24, 2023

Sorry @viniciusdc I didn't see this PR, I just opened a similar one #312 . I will close mine in favor of this one.

@pavithraes
Copy link
Member

@viniciusdc I'm comfortable merging this PR and making updates later if needed. What to do you think?

@pavithraes pavithraes added status: approved 💪🏾 This PR has been reviewed and approved for merge and removed status: in progress 🏗 This task is currently being worked on labels May 1, 2023
@viniciusdc
Copy link
Contributor Author

@viniciusdc I'm comfortable merging this PR and making updates later if needed. What to do you think?

Sounds great, thanks @pavithraes !

@pavithraes pavithraes dismissed costrouc’s stale review May 1, 2023 21:31

Requested changes done!

@pavithraes pavithraes merged commit 29902ac into main May 1, 2023
@pavithraes pavithraes deleted the issue-296/idle-culling-settings branch May 1, 2023 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: approved 💪🏾 This PR has been reviewed and approved for merge type: enhancement 💅🏼 New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOC] - Write docs for idle-culling settings
4 participants