Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add installation docs for JHub App Launcher #391

Merged
merged 6 commits into from
Jan 11, 2024
Merged

Conversation

aktech
Copy link
Member

@aktech aktech commented Jan 7, 2024

Reference Issues or PRs

This is just to add the installation instruction in the docs, more usage docs will go in jhub-apps docs site, which is not up yet.

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Documentation

Access-centered content checklist

Text styling

  • The content is written with plain language (where relevant).
  • If there are headers, they use the proper header tags (with only one level-one header: H1 or # in markdown).
  • All links describe where they link to (for example, check the Nebari website).
  • This content adheres to the Nebari style guides.

Non-text content

  • All content is represented as text (for example, images need alt text, and videos need captions or descriptive transcripts).
  • If there are emojis, there are not more than three in a row.
  • Don't use flashing GIFs or videos.
  • If the content were to be read as plain text, it still makes sense, and no information is missing.

Any other comments?

Copy link

netlify bot commented Jan 7, 2024

Deploy Preview for nebari-docs ready!

Name Link
🔨 Latest commit c8e9076
🔍 Latest deploy log https://app.netlify.com/sites/nebari-docs/deploys/65a030d957b5430008aa86a8
😎 Deploy Preview https://deploy-preview-391--nebari-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@pavithraes pavithraes self-requested a review January 8, 2024 14:53
@pavithraes pavithraes added type: enhancement 💅🏼 New feature or request needs: review 👀 This PR is complete and ready for reviewing labels Jan 8, 2024
@pavithraes pavithraes added this to the 2024.1.1 milestone Jan 9, 2024
Copy link
Member

@pavithraes pavithraes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I have a couple of suggestions, that I'll commit and merge. :)

docs/docs/how-tos/jhub-app-launcher.md Outdated Show resolved Hide resolved
docs/docs/how-tos/jhub-app-launcher.md Show resolved Hide resolved
docs/docs/how-tos/jhub-app-launcher.md Outdated Show resolved Hide resolved
@pavithraes pavithraes merged commit 2f9b9f8 into main Jan 11, 2024
6 checks passed
@pavithraes pavithraes deleted the jhub-apps-docs branch January 11, 2024 18:19
@pavithraes pavithraes added status: approved 💪🏾 This PR has been reviewed and approved for merge and removed needs: review 👀 This PR is complete and ready for reviewing labels Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: approved 💪🏾 This PR has been reviewed and approved for merge type: enhancement 💅🏼 New feature or request
Projects
Status: Done 💪🏾
Development

Successfully merging this pull request may close these issues.

2 participants