Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure into multiple instances #476

Merged
merged 9 commits into from
Sep 10, 2024

Conversation

pavithraes
Copy link
Member

@pavithraes pavithraes commented Jun 13, 2024

Reference Issues or PRs

Closes #359
Addresses #435

This pull request:

  • Moves the "Community" pages into a separate instance, with a separate sidebar
  • Creates a new instance for Nebari Slurm docs
  • Updates top navbar to mention new projects
  • Misc clean-up and consistency fixes

TODOs before merging

  • Verify internal links are not broken by this change

Comments

Signed-off-by: Pavithra Eswaramoorthy <pavithraes@outlook.com>
@pavithraes pavithraes marked this pull request as draft June 13, 2024 00:02
Copy link

netlify bot commented Jun 13, 2024

Deploy Preview for nebari-docs ready!

Name Link
🔨 Latest commit 61e8671
🔍 Latest deploy log https://app.netlify.com/sites/nebari-docs/deploys/66d6e2e9a3dbac0008bb6244
😎 Deploy Preview https://deploy-preview-476--nebari-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@pavithraes pavithraes added the status: in progress 🏗 This task is currently being worked on label Jun 13, 2024
Signed-off-by: Pavithra Eswaramoorthy <pavithraes@outlook.com>
Signed-off-by: Pavithra Eswaramoorthy <pavithraes@outlook.com>
Signed-off-by: Pavithra Eswaramoorthy <pavithraes@outlook.com>
Signed-off-by: Pavithra Eswaramoorthy <pavithraes@outlook.com>
@pavithraes pavithraes marked this pull request as ready for review August 16, 2024 14:11
@pavithraes pavithraes changed the title [WIP] Restructure into multiple instances Restructure into multiple instances Aug 16, 2024
@viniciusdc
Copy link
Contributor

Absolutely fantastic work, thanks @pavithraes 🚀

@viniciusdc viniciusdc mentioned this pull request Aug 16, 2024
18 tasks
@viniciusdc
Copy link
Contributor

Hi @pavithraes do you mind if I take over the remaining changes this PR requires to be fully merged? aka. the conflicts above.

Signed-off-by: Pavithra Eswaramoorthy <pavithraes@outlook.com>
… sidebar, misc updates

Signed-off-by: Pavithra Eswaramoorthy <pavithraes@outlook.com>
Signed-off-by: Pavithra Eswaramoorthy <pavithraes@outlook.com>
Signed-off-by: Pavithra Eswaramoorthy <pavithraes@outlook.com>
@pavithraes
Copy link
Member Author

@viniciusdc - I've fixed the conflicts, please take a look when you get a chance :)

Copy link
Contributor

@viniciusdc viniciusdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @pavithraes

@viniciusdc
Copy link
Contributor

I will hold this till tomorrow, to have proper time to review the child issues related to those changes as well

@viniciusdc viniciusdc mentioned this pull request Sep 3, 2024
18 tasks
@viniciusdc viniciusdc merged commit a89fe3f into nebari-dev:main Sep 10, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: in progress 🏗 This task is currently being worked on
Projects
Status: Done 💪🏾
Development

Successfully merging this pull request may close these issues.

[DOC] - Move Community into a separate sidebar
2 participants