-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructure into multiple instances #476
Conversation
Signed-off-by: Pavithra Eswaramoorthy <pavithraes@outlook.com>
✅ Deploy Preview for nebari-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Pavithra Eswaramoorthy <pavithraes@outlook.com>
Signed-off-by: Pavithra Eswaramoorthy <pavithraes@outlook.com>
Signed-off-by: Pavithra Eswaramoorthy <pavithraes@outlook.com>
Signed-off-by: Pavithra Eswaramoorthy <pavithraes@outlook.com>
Absolutely fantastic work, thanks @pavithraes 🚀 |
Hi @pavithraes do you mind if I take over the remaining changes this PR requires to be fully merged? aka. the conflicts above. |
Signed-off-by: Pavithra Eswaramoorthy <pavithraes@outlook.com>
… sidebar, misc updates Signed-off-by: Pavithra Eswaramoorthy <pavithraes@outlook.com>
Signed-off-by: Pavithra Eswaramoorthy <pavithraes@outlook.com>
@viniciusdc - I've fixed the conflicts, please take a look when you get a chance :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @pavithraes
I will hold this till tomorrow, to have proper time to review the child issues related to those changes as well |
Reference Issues or PRs
Closes #359
Addresses #435
This pull request:
TODOs before merging
Comments