-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CDS dashboard tutorial #52
Conversation
✅ Deploy Preview for nebari-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @sayantikabanik ! This is a great start. I'd also like to see this page appear in the document itself. I think adding it here should do the trick.
Once you've worked through my comments here and have this page displayed as part of the docs, I'll review again.
Co-authored-by: Kim Pevey <kcpevey@quansight.com>
Co-authored-by: Kim Pevey <kcpevey@quansight.com>
Co-authored-by: Kim Pevey <kcpevey@quansight.com>
Co-authored-by: Kim Pevey <kcpevey@quansight.com>
Co-authored-by: Kim Pevey <kcpevey@quansight.com>
Co-authored-by: Kim Pevey <kcpevey@quansight.com>
Co-authored-by: Kim Pevey <kcpevey@quansight.com>
Co-authored-by: Kim Pevey <kcpevey@quansight.com>
Co-authored-by: Kim Pevey <kcpevey@quansight.com>
Co-authored-by: Kim Pevey <kcpevey@quansight.com>
Co-authored-by: Kim Pevey <kcpevey@quansight.com>
Co-authored-by: Kim Pevey <kcpevey@quansight.com>
Co-authored-by: Kim Pevey <kcpevey@quansight.com>
Thank you @kcpevey. I have incorporated the suggestions and I'm able to render the document under |
Co-authored-by: Kim Pevey <kcpevey@quansight.com>
Co-authored-by: Kim Pevey <kcpevey@quansight.com>
Co-authored-by: Kim Pevey <kcpevey@quansight.com>
Co-authored-by: Kim Pevey <kcpevey@quansight.com>
Co-authored-by: Kim Pevey <kcpevey@quansight.com>
Co-authored-by: Kim Pevey <kcpevey@quansight.com>
Co-authored-by: Kim Pevey <kcpevey@quansight.com>
Co-authored-by: Kim Pevey <kcpevey@quansight.com>
Co-authored-by: Kim Pevey <kcpevey@quansight.com>
Co-authored-by: Kim Pevey <kcpevey@quansight.com>
Co-authored-by: Kim Pevey <kcpevey@quansight.com>
Co-authored-by: Kim Pevey <kcpevey@quansight.com>
Co-authored-by: Kim Pevey <kcpevey@quansight.com>
Co-authored-by: Kim Pevey <kcpevey@quansight.com>
This is looking great @sayantikabanik and @kcpevey! I like the tree dataset ;) This made me think of the tree dataset we added to the quansight.qhub.dev intake catalog a few weeks ago. Perhaps at some later date we could integrate those datasets into our tutorials in general. I created this issue to track the general idea: nebari-dev/nebari#56 |
@iameskild that is a good point. I want to use that intake catalog as a basis for all our demos. We started out creating a little package for it, but work for that dropped off. I'll comment on the issue you created. I will give this one last review sometime today. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sayantikabanik I made a few small edits to the instance (profile) section. Once those changes are, feel free to merge :)
Co-authored-by: eskild <42120229+iameskild@users.noreply.github.com>
Co-authored-by: eskild <42120229+iameskild@users.noreply.github.com>
Co-authored-by: eskild <42120229+iameskild@users.noreply.github.com>
Thanks, @iameskild for me it shows |
resolves #13
Currently I have added a self contained example (without using any external dataset). Happy to add advance examples if required.
This is my first attempt to create documentation using
diataxis framework
. Open this PR to gather feedback and update accordingly.