Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH - Add jinja linter #11

Merged
merged 4 commits into from
Jan 16, 2023
Merged

ENH - Add jinja linter #11

merged 4 commits into from
Jan 16, 2023

Conversation

trallard
Copy link
Member

@trallard trallard commented Jan 16, 2023 •
edited
Loading

This PR adds the following:

  • Update the pre-commit hooks and add pre-commit CI config
  • Adds a jinja linter, which until now was missing from this repo
  • It also fixes some linting issues

@trallard trallard added area: ci 👷🏽‍♀️ Items related to CI and CD area: dependencies 📦 needs: review 👀 This PR is complete and ready for reviewing type: enhancement 💅🏼 New feature or request labels Jan 16, 2023
pavithraes
pavithraes approved these changes Jan 16, 2023
View reviewed changes
Copy link
Member

@pavithraes pavithraes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @trallard! Looks good to me. :)

@trallard trallard merged commit aed75c7 into main Jan 16, 2023
@trallard trallard deleted the trallard/pre-commit branch January 16, 2023 18:30
@pavithraes pavithraes added status: approved 💪🏾 This PR has been reviewed and approved for merge and removed needs: review 👀 This PR is complete and ready for reviewing labels Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavithraes pavithraes pavithraes approved these changes

@iameskild iameskild Awaiting requested review from iameskild

Assignees
No one assigned
Labels
area: ci 👷🏽‍♀️ Items related to CI and CD area: dependencies 📦 status: approved 💪🏾 This PR has been reviewed and approved for merge type: enhancement 💅🏼 New feature or request
Projects
🪴 Nebari Project Management
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trallard @pavithraes