[enhancement] clear out stages before re-render #1049
Comments
viniciusdc
changed the title
viniciusdc
added
area: architecture
area: user experience 👩🏻💻
needs: discussion 💬
|
c.c @costrouc @danlester |
|
Really tf files need to be removed in case any were deleted between old and newer versions of QHub. I have run into this in development just now, but the same could happen between full versions. |
|
Closes #1062 |
|
We've had two meetings this week that discuss this issue. I'm against deleting anything that is encountered within these directories and instead having a "deprecated filenames/directories" list. We've talked about having a deprication approach. I'll have a PR that addresses this issue and up for review by end of day. |
Cool, I will gladly review it |
Closes #1049 This is to provide a simple mechanism for deprication of files and allowing for targeted deletion of files. Later this functionality can be extented to provide qhub extensions the ability to depricate files within a stage. For how this is just a single list that is populated.
…1073) * Adds the ability on render to deleted targeted files or directories Closes #1049 This is to provide a simple mechanism for deprication of files and allowing for targeted deletion of files. Later this functionality can be extented to provide qhub extensions the ability to depricate files within a stage. For how this is just a single list that is populated. * Black formatting * Adding qhub/depricate.py to address explicit deprication of files * Black formatting * Need to learn to spell 😄
…1073) * Adds the ability on render to deleted targeted files or directories Closes #1049 This is to provide a simple mechanism for deprication of files and allowing for targeted deletion of files. Later this functionality can be extented to provide qhub extensions the ability to depricate files within a stage. For how this is just a single list that is populated. * Black formatting * Adding qhub/depricate.py to address explicit deprication of files * Black formatting * Need to learn to spell 😄
As pointed out by @danlester, we should remove some files from the stages directory before re-attempting a qhub deploy (redeploy), as it would be more secure for the user as well as would decrease the chance of terraform complaining or erroring during deployment. e.g.
As per #1010, currently, we have a way to discern which files exist only in the user space (now, untracked), so we can add a filter to remove some target files like the state ones.
Enhancements
qhub render --remove [01-terraform-state/<untracked-file>]--disable-promptas well)The text was updated successfully, but these errors were encountered: