Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Update CI/CD workflows to work within community contributors' PRs #1301

Closed
viniciusdc opened this issue May 27, 2022 · 1 comment
Closed

Comments

@viniciusdc
Copy link
Contributor

Some of our actions require extra secrets to be set in order to work (e.g. Kubernetes tests and cloud providers). Due to this, in the scenario where a new contributor forks the repo, any changes to the future PR will not fail the mentioned test, blocking some pipelines and the reviewing process.

Task

  • Review current test structure to avoid such scenario

Success criteria

  • The contributor should be able to open a PR to Quansight/qhub.git@main from a fork, and the tests should all run, without requiring extra configurations.
@viniciusdc viniciusdc added this to the Future Planning milestone May 27, 2022
@viniciusdc viniciusdc changed the title [ENH] Update CI/CD workflows to work within comunity contributors PRs [ENH] Update CI/CD workflows to work within community contributors' PRs May 27, 2022
@HarshCasper HarshCasper self-assigned this May 27, 2022
@aktech
Copy link
Member

aktech commented Nov 30, 2022

This was fixed in #1563

@aktech aktech closed this as completed Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants