Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Facilitate CI run for contributor PR #1568

Merged

Conversation

aktech
Copy link
Member

@aktech aktech commented Nov 25, 2022

Reference Issues or PRs #1301

With this members can trigger CI on contributor's PR with the following comment on the PR:

/bot run tests

TODO (right before merging the PR):

  • Change contributor-ci-workflow -> main in the .github/workflows/contributor.yaml

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

@aktech aktech force-pushed the contributor-ci-workflow branch from ad33e8a to b6e13bc Compare November 25, 2022 15:28
@aktech aktech changed the title Facilitate contributor CI run for contributor PR Facilitate CI run for contributor PR Nov 25, 2022
@aktech aktech force-pushed the contributor-ci-workflow branch 3 times, most recently from 31cf5dc to a8f0aef Compare November 26, 2022 13:17
@aktech
Copy link
Member Author

aktech commented Nov 26, 2022

/bot run tests

@github-actions
Copy link

Contributor Tests Triggered by @aktech

@aktech aktech force-pushed the contributor-ci-workflow branch from c85035c to ba04b4c Compare November 28, 2022 18:50
@aktech
Copy link
Member Author

aktech commented Nov 28, 2022

/bot run tests

@github-actions
Copy link

Contributor Tests Triggered by @aktech

@aktech aktech force-pushed the contributor-ci-workflow branch from ba04b4c to 4e6bdbd Compare November 28, 2022 19:04
@aktech
Copy link
Member Author

aktech commented Nov 28, 2022

/bot run tests

@github-actions
Copy link

Contributor Tests Triggered by @aktech

@aktech aktech force-pushed the contributor-ci-workflow branch from 4e6bdbd to 2e6822b Compare November 29, 2022 12:23
@aktech
Copy link
Member Author

aktech commented Nov 29, 2022

/bot run tests

@github-actions
Copy link

Contributor Tests Triggered by @aktech

@aktech aktech force-pushed the contributor-ci-workflow branch from 2e6822b to d7b30a4 Compare November 29, 2022 14:00
@aktech
Copy link
Member Author

aktech commented Nov 29, 2022

/bot run tests

@github-actions
Copy link

Contributor Tests Triggered by @aktech

Copy link
Member

@iameskild iameskild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great!! We can merge this as is or wait until we finalize our gitflow workflow decision 👍

@iameskild iameskild added this to the Release 2022.11.1 milestone Nov 30, 2022
@iameskild iameskild merged commit eb6d01b into nebari-dev:release/2022.11.1 Nov 30, 2022
@aktech aktech deleted the contributor-ci-workflow branch November 30, 2022 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants