Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] - Newest release of nebari overrides supplied values for existing and local deployment and existing is broken #2086

Closed
costrouc opened this issue Oct 24, 2023 · 1 comment · Fixed by #2087
Closed

[BUG] - Newest release of nebari overrides supplied values for existing and local deployment and existing is broken #2086

costrouc opened this issue Oct 24, 2023 · 1 comment · Fixed by #2087
Labels
impact: medium 🟨 This item affects some users, not critical needs: documentation 📖 This item is missing docs needs: PR 📬 This item has been scoped and needs to be worked on needs: tests ✅ This contribution is missing tests type: bug 🐛 Something isn't working

Comments

@costrouc
Copy link
Member

costrouc commented Oct 24, 2023 •
edited
Loading

Describe the bug

Existing provider is broken due to

nebari/src/_nebari/stages/infrastructure/__init__.py

Lines 546 to 547 in 376ffba

if provider in ["local", "existing"]:
values[provider] = provider_enum_model_map[provider]()
. Additionally the default values for local and existing are always applied which breaks does not allow local / existing deployments. It is complaining with a kube_context being not and is ignoring my configuration for existing.

Expected behavior

Should preserve local/existing deployment

OS and architecture in which you are running Nebari

latest 2023.10.1.

How to Reproduce the problem?

provider: existing
existing:
  kube_context: thisisacontext

Command output

No response

Versions and dependencies used.

No response

Compute environment

None

Integrations

No response

Anything else?

No response
@costrouc costrouc added type: bug 🐛 Something isn't working needs: triage 🚦 Someone needs to have a look at this issue and triage labels Oct 24, 2023
@pavithraes pavithraes added needs: documentation 📖 This item is missing docs needs: PR 📬 This item has been scoped and needs to be worked on impact: medium 🟨 This item affects some users, not critical and removed needs: triage 🚦 Someone needs to have a look at this issue and triage labels Oct 24, 2023
@fangchenli
Copy link
Member

relate to #2064

@pavithraes pavithraes added the needs: tests ✅ This contribution is missing tests label Oct 24, 2023
fangchenli added a commit to fangchenli/nebari that referenced this issue Oct 24, 2023
@fangchenli
BUG: fix incorrect config override nebari-dev#2086
d04de10
@fangchenli fangchenli mentioned this issue Oct 24, 2023
Merged
10 tasks
iameskild pushed a commit that referenced this issue Oct 24, 2023
@fangchenli
BUG: fix incorrect config override #2086 (#2087)
b254cc8
@github-project-automation github-project-automation bot moved this from New 🚦 to Done 💪🏾 in 🪴 Nebari Project Management Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
impact: medium 🟨 This item affects some users, not critical needs: documentation 📖 This item is missing docs needs: PR 📬 This item has been scoped and needs to be worked on needs: tests ✅ This contribution is missing tests type: bug 🐛 Something isn't working
Projects
🪴 Nebari Project Management
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

BUG: fix incorrect config override #2086 fangchenli/nebari
3 participants
@costrouc @fangchenli @pavithraes