You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently E2E tests verify that overrides.json have an effect on the deployed application (see e8a723e introduced in #2249); the configs in jupyter_server_config.py and configs for jupyter_pioneer do not have similar checks.
Expected behavior
These checks do not need to verify all options, but one or two just to ensure that the configuration file actually is loaded up in the deployment (is in correct place, etc). #2286 adds a very simple check against syntax errors in the config files but it does not verify if the files get placed in the correct place.
OS and architecture in which you are running Nebari
2024.1.2
How to Reproduce the problem?
See that CI on develop was green even though the config files had syntax errors.
Command output
No response
Versions and dependencies used.
No response
Compute environment
None
Integrations
No response
Anything else?
No response
The text was updated successfully, but these errors were encountered:
Describe the bug
Currently E2E tests verify that
overrides.json
have an effect on the deployed application (see e8a723e introduced in #2249); the configs injupyter_server_config.py
and configs for jupyter_pioneer do not have similar checks.Expected behavior
These checks do not need to verify all options, but one or two just to ensure that the configuration file actually is loaded up in the deployment (is in correct place, etc). #2286 adds a very simple check against syntax errors in the config files but it does not verify if the files get placed in the correct place.
OS and architecture in which you are running Nebari
2024.1.2
How to Reproduce the problem?
See that CI on
develop
was green even though the config files had syntax errors.Command output
No response
Versions and dependencies used.
No response
Compute environment
None
Integrations
No response
Anything else?
No response
The text was updated successfully, but these errors were encountered: