Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - Jupyter configs should be verified in E2E tests #2287

Open
krassowski opened this issue Mar 4, 2024 · 0 comments
Open

[BUG] - Jupyter configs should be verified in E2E tests #2287

krassowski opened this issue Mar 4, 2024 · 0 comments
Labels
area: testing ✅ Testing type: bug 🐛 Something isn't working

Comments

@krassowski
Copy link
Member

Describe the bug

Currently E2E tests verify that overrides.json have an effect on the deployed application (see e8a723e introduced in #2249); the configs in jupyter_server_config.py and configs for jupyter_pioneer do not have similar checks.

Expected behavior

These checks do not need to verify all options, but one or two just to ensure that the configuration file actually is loaded up in the deployment (is in correct place, etc). #2286 adds a very simple check against syntax errors in the config files but it does not verify if the files get placed in the correct place.

OS and architecture in which you are running Nebari

2024.1.2

How to Reproduce the problem?

See that CI on develop was green even though the config files had syntax errors.

Command output

No response

Versions and dependencies used.

No response

Compute environment

None

Integrations

No response

Anything else?

No response

@krassowski krassowski added type: bug 🐛 Something isn't working needs: triage 🚦 Someone needs to have a look at this issue and triage labels Mar 4, 2024
@marcelovilla marcelovilla removed the needs: triage 🚦 Someone needs to have a look at this issue and triage label May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: testing ✅ Testing type: bug 🐛 Something isn't working
Projects
Status: New 🚦
Development

No branches or pull requests

3 participants