Fix syntax error in jupyter-server-config Python file

[krassowski]

Reference Issues or PRs

• Ensures deployment fails when there is a syntax error in the file
• Fixes [BUG] - Notebook Jobs failing because environment is not found #2277 by adding missing quotes

What does this implement/fix?

Put a x in the boxes that apply

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds a feature)
• Breaking change (fix or feature that would cause existing features not to work as expected)
• Documentation Update
• Code style update (formatting, renaming)
• Refactoring (no functional changes, no API changes)
• Build related changes
• Other (please describe):

Testing

• Did you test the pull request locally?
• Did you add new tests?

Any other comments?

[krassowski]

Great, d140bf7 uncovered another existing but silent issue, 🎉:

[terraform]: ╷
[terraform]: │ Error: local-exec provisioner error
[terraform]: │ 
[terraform]: │   with module.jupyterhub.local_file.jupyter_jupyterlab_pioneer_config_py,
[terraform]: │   on modules/kubernetes/services/jupyterhub/configmaps.tf line 44, in resource "local_file" "jupyter_jupyterlab_pioneer_config_py":
[terraform]: │   44:   provisioner "local-exec" {
[terraform]: │ 
[terraform]: │ Error running command 'python -m py_compile
[terraform]: │ modules/kubernetes/services/jupyterhub/files/jupyter/jupyter_jupyterlab_pioneer_config.py':
[terraform]: │ exit status 1. Output:   File
[terraform]: │ "modules/kubernetes/services/jupyterhub/files/jupyter/jupyter_jupyterlab_pioneer_config.py",
[terraform]: │ line 6
[terraform]: │     log_format =
[terraform]: │                 ^
[terraform]: │ SyntaxError: invalid syntax
[terraform]: │ 
[terraform]: │ 
[terraform]: ╵

[krassowski]

While the provisioner script added in this PR adds a guard against syntax error, it does not actually ensure that the configs are applied (imagine that someone makes a typo in a future PR and places the config in a wrong directory). The end-to-end tests should pick it up, but failed to detect the problems for either pioneer and plain server config. I will open a new issue for this. Edit, here it goes: #2287

[krassowski]

@marcelovilla this is now all passing, should we go ahead with trying out the branch in a deployment?

[marcelovilla]

Thanks @krassowski! Just tested this on a new deployment and I am able to submit notebook jobs.

[marcelovilla]

Closes #2277