Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable authentication by default in jupyter-server #2288

Merged
merged 6 commits into from
Jun 27, 2024

Conversation

krassowski
Copy link
Member

Reference Issues or PRs

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

@marcelovilla
Copy link
Member

@krassowski what's the status of this? Is there anything we need to discuss to incorporate this?

@krassowski krassowski marked this pull request as ready for review April 8, 2024 18:07
@krassowski
Copy link
Member Author

Sorry, I forgot to undraft once the other PRs got merged. I think we should give it a try.

@marcelovilla
Copy link
Member

@krassowski tests are failing with:

First Test -- Check Nebari login and start JupyterLab (failed)

Can't check the full event log, though. Anything comes to mind?

@krassowski
Copy link
Member Author

Back to draft. I need to make a PR to jupyterhub.

@krassowski krassowski marked this pull request as draft April 9, 2024 17:23
@krassowski
Copy link
Member Author

jupyterhub/jupyterhub#4779 was merged, we will need to wait with this one for a new JupyterHub release

@krassowski krassowski marked this pull request as ready for review May 24, 2024 16:16
@krassowski
Copy link
Member Author

With JupyterHub 5 in we should be able to make progress here.

@krassowski
Copy link
Member Author

By which I meant that this is ready to go into the next release (maybe not the upcoming one yet, but let's merge is ASAP after the release is out).

@marcelovilla marcelovilla added this to the 2024.7.1 milestone Jun 27, 2024
@marcelovilla
Copy link
Member

Thanks @krassowski ! Now that the release is out, should we merge this for the next one?

@krassowski
Copy link
Member Author

Yes, thank you for remembering about it!

@krassowski krassowski merged commit 85849a3 into nebari-dev:develop Jun 27, 2024
11 checks passed
Adam-D-Lewis pushed a commit that referenced this pull request Jun 28, 2024
Co-authored-by: Marcelo Villa <mvilla@quansight.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

2 participants