-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable authentication by default in jupyter-server #2288
Enable authentication by default in jupyter-server #2288
Conversation
@krassowski what's the status of this? Is there anything we need to discuss to incorporate this? |
Sorry, I forgot to undraft once the other PRs got merged. I think we should give it a try. |
@krassowski tests are failing with: Can't check the full event log, though. Anything comes to mind? |
Back to draft. I need to make a PR to jupyterhub. |
jupyterhub/jupyterhub#4779 was merged, we will need to wait with this one for a new JupyterHub release |
With JupyterHub 5 in we should be able to make progress here. |
By which I meant that this is ready to go into the next release (maybe not the upcoming one yet, but let's merge is ASAP after the release is out). |
Thanks @krassowski ! Now that the release is out, should we merge this for the next one? |
Yes, thank you for remembering about it! |
Co-authored-by: Marcelo Villa <mvilla@quansight.com>
Reference Issues or PRs
What does this implement/fix?
Put a
x
in the boxes that applyTesting
Any other comments?