Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Jupyterlab docker build #1001

Merged
merged 15 commits into from
Jan 20, 2022
Merged

Fix Jupyterlab docker build #1001

merged 15 commits into from
Jan 20, 2022

Conversation

viniciusdc
Copy link
Contributor

@viniciusdc viniciusdc commented Jan 19, 2022

Fixes #1000

On December 16th code-server repo updated their install.sh file, and updated their download URLs, causing the postbuild phase for the Jupyterlab image to fail. This PR updates the download URL for their installer.

Also, on January 18th our docker build/push action got a new release including support for Handlebars, which conflicted with our main path for template images: ./qhub/templates/{{ cookiecutter.repo_directory }}, as they seem to have added some kind of parser for the handlers that broke our workflow.

Changes:

  • Updates the snapshot URL for code-server bash installer
  • Add symlink for ./qhub/templates/{{ cookiecutter.repo_directory }} --> ./qhub/templates/cookiecutter, and treeinspection over the symlink dir.

Types of changes

What types of changes does your code introduce?

Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • Yes
  • No

@viniciusdc viniciusdc added this to the Release v0.4.0 milestone Jan 19, 2022
@viniciusdc viniciusdc added the needs: review 👀 This PR is complete and ready for reviewing label Jan 19, 2022
Copy link
Member

@iameskild iameskild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks @viniciusdc :)

@viniciusdc viniciusdc merged commit f163325 into main Jan 20, 2022
@viniciusdc viniciusdc deleted the fix-jupyterlab-postbuild branch August 18, 2022 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: review 👀 This PR is complete and ready for reviewing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix docker image build workflows
2 participants