-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a new lint pipeline for Python and Terraform #1007
Conversation
Hi, @HarshCasper @iameskild have you tested the Py3.10 deployment? last time there was a problem with the google API client (it seems they now support it ) but its worth checking |
@iameskild @HarshCasper what are your thoughts on closing this and re-opening once the Nebari migration is completed? |
@viniciusdc I'm fine with closing this one. I think #1282 will replace the changes proposed here. |
Wonderful, I will close this then. The mention above should be considered when merging 1282 to be sure we pick the changes presented here as well. |
Fixes | Closes | Resolves #
#1005
Changes:
lint.yaml
for Python and Terraform lintingif:
condition to ensure that the workflow only runs forquansight/qhub
Types of changes
What types of changes does your code introduce?
Put an
x
in the boxes that applyTesting
Requires testing
In case you checked yes, did you write tests?
Further comments (optional)
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered and more.