Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new lint pipeline for Python and Terraform #1007

Closed
wants to merge 5 commits into from
Closed

Conversation

iameskild
Copy link
Member

@iameskild iameskild commented Jan 25, 2022

Fixes | Closes | Resolves #
#1005

Please remove anything marked as optional that you don't need to fill in. Choose one of the keywords preceding to refer to the issue this PR solves, followed by the issue number (e.g Fixes # 666). If there is no issue, remove the line. Remove this note after reading.

Changes:

  • Create a new lint.yaml for Python and Terraform linting
  • Formats all the Terraform format
  • Adds support for Python 3.10
  • Adds an if: condition to ensure that the workflow only runs for quansight/qhub

Types of changes

What types of changes does your code introduce?

Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • Yes
  • No

In case you checked yes, did you write tests?

  • Yes
  • No

Further comments (optional)

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered and more.

@trallard trallard added the type: maintenance 🛠 Day-to-day maintenance tasks label Feb 25, 2022
@viniciusdc viniciusdc added this to the Future Planning milestone Apr 26, 2022
@HarshCasper HarshCasper changed the title Create new lint.yaml Add a new lint pipeline for Python and Terraform May 10, 2022
@HarshCasper HarshCasper marked this pull request as ready for review May 10, 2022 06:38
@viniciusdc
Copy link
Contributor

Hi, @HarshCasper @iameskild have you tested the Py3.10 deployment? last time there was a problem with the google API client (it seems they now support it ) but its worth checking

@viniciusdc
Copy link
Contributor

@iameskild @HarshCasper what are your thoughts on closing this and re-opening once the Nebari migration is completed?

@iameskild
Copy link
Member Author

@viniciusdc I'm fine with closing this one. I think #1282 will replace the changes proposed here.

@viniciusdc
Copy link
Contributor

Wonderful, I will close this then. The mention above should be considered when merging 1282 to be sure we pick the changes presented here as well.

@viniciusdc viniciusdc closed this May 24, 2022
@viniciusdc viniciusdc deleted the linting branch May 24, 2022 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: maintenance 🛠 Day-to-day maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants