Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOCS: QHub 101 #1011

Merged
merged 5 commits into from
Feb 19, 2022
Merged

DOCS: QHub 101 #1011

merged 5 commits into from
Feb 19, 2022

Conversation

HarshCasper
Copy link
Contributor

Fixes #301

@HarshCasper HarshCasper marked this pull request as draft February 2, 2022 18:50
@magsol
Copy link
Contributor

magsol commented Feb 2, 2022

This seems like a good start but I'm not convinced this "fixes" #301, especially given the spaCy example that Tania posted. I think we need to fill out the skeleton with some content before we merge.

@HarshCasper
Copy link
Contributor Author

This seems like a good start but I'm not convinced this "fixes" #301, especially given the spaCy example that Tania posted. I think we need to fill out the skeleton with some content before we merge.

Hi @magsol

I am currently working on this. I just added the skeleton here to act as a base for me to further push the apt content 😅

I have kept the PR as a draft and will make it open for review once I am done with it.

@magsol
Copy link
Contributor

magsol commented Feb 3, 2022

I am currently working on this. I just added the skeleton here to act as a base for me to further push the apt content 😅

I have kept the PR as a draft and will make it open for review once I am done with it.

Ack, sorry! My mistake. Carry on :)

@HarshCasper HarshCasper marked this pull request as ready for review February 8, 2022 15:47
@trallard trallard added the area: documentation 📖 Improvements or additions to documentation label Feb 18, 2022
@trallard
Copy link
Member

what is the status of this? @HarshCasper @magsol

@magsol
Copy link
Contributor

magsol commented Feb 18, 2022

what is the status of this? @HarshCasper @magsol

Ah! I somehow missed Harsh's most recent changes. I'll review as soon as I can. Thanks @HarshCasper !

@magsol
Copy link
Contributor

magsol commented Feb 18, 2022

@HarshCasper I fixed some spelling errors that GitHub flagged, but I'm still seeing link 404s in the Actions. Visual inspection says that these links are fine, but I wanted to check with you before merging.

@HarshCasper
Copy link
Contributor Author

@HarshCasper I fixed some spelling errors that GitHub flagged, but I'm still seeing link 404s in the Actions. Visual inspection says that these links are fine, but I wanted to check with you before merging.

I have fixed all of them. Thanks for fixing the Vale errors :)

@magsol
Copy link
Contributor

magsol commented Feb 19, 2022

Looks like there are some Vale errors in other docs but those can be fixed in a separate PR. I'll go ahead and merge this as soon as I can.

magsol
magsol approved these changes Feb 19, 2022
View reviewed changes
Copy link
Contributor

@magsol magsol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vale errors were fixed, looks good to merge.

@magsol magsol merged commit 6736717 into main Feb 19, 2022
@magsol magsol deleted the qhub-101-doc branch February 19, 2022 16:55
tylerpotts pushed a commit that referenced this pull request Feb 21, 2022
@HarshCasper @magsol @tylerpotts
DOCS: QHub 101 (#1011)
8fee95f 
* DOCS: Add skeleton for QHub 101

* DOC: Add QHub 101 doc for general-purpose overview

* Fixed multiple Vale style checks and spelling errors.

* FIX: Fix broken links

Co-authored-by: Shannon Quinn <magsol@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magsol magsol magsol approved these changes

@costrouc costrouc Awaiting requested review from costrouc

Assignees
No one assigned
Labels
area: documentation 📖 Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[documentation] - 101 Qhub
3 participants
@HarshCasper @magsol @trallard