Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix formatting issues with black #1003 #1020

Merged
merged 4 commits into from
Feb 3, 2022
Merged

Fix formatting issues with black #1003 #1020

merged 4 commits into from
Feb 3, 2022

Conversation

viniciusdc
Copy link
Contributor

@viniciusdc viniciusdc commented Feb 3, 2022

Fixes #1018

Changes:

  • black some missing files and format using flake8
  • add an exception for traitlets config over testing actions

Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

costrouc
costrouc previously approved these changes Feb 3, 2022
@costrouc costrouc dismissed their stale review February 3, 2022 17:22

Would like a code change

@costrouc
Copy link
Member

costrouc commented Feb 3, 2022

@viniciusdc could you add builtins to the setup.cfg instead so that it is used always with flake8. Instead of as a command line option.

@viniciusdc
Copy link
Contributor Author

@viniciusdc could you add builtins to the setup.cfg instead so that it is used always with flake8. Instead of as a command line option.

Oh, thanks @costrouc, I totally forgot about it.

@costrouc costrouc merged commit 3815ff4 into main Feb 3, 2022
@costrouc costrouc deleted the fix-formatting branch February 3, 2022 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[fix] Formating issues from #1003
2 participants