Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix input variable support for multiple types #1029

Merged
merged 3 commits into from
Feb 4, 2022
Merged

Fix input variable support for multiple types #1029

merged 3 commits into from
Feb 4, 2022

Conversation

viniciusdc
Copy link
Contributor

@viniciusdc viniciusdc commented Feb 4, 2022

Fixes #1028

The current map type for authentication lead to terraform to decide the type of variables it will be receiving from the input. But, when using extra forms of authentication like Github, Auth0 the extra field authentication.config has a dict type structure, and authentication.type has an str type structure which lead to the following error when deploying the stage:

... map elements must have the same type.

edit.: Opted for variable type: any as using object structure obliges the variable input to have the same structure as specified which conflicts with the authentication modes of qhub (some does not include the config key)

Changes:

  • Update variable authentication type to include multiple value types.

Types of changes

What types of changes does your code introduce?

Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • Yes
  • No

In case you checked yes, did you write tests?

  • Yes
  • No

Further comments (optional)

Already tested on minikube local deployment with Auth0 config.

@viniciusdc viniciusdc requested a review from iameskild February 4, 2022 19:42
Copy link
Member

@costrouc costrouc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@viniciusdc makes perfect sense. Thank you for the detailed explanation on the problem.

@costrouc costrouc merged commit 2de5317 into main Feb 4, 2022
@costrouc costrouc deleted the fix-1028-auth branch February 4, 2022 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] Invalid value for input variable 'authentication'
2 participants