Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stage 08 extensions and realms/logout #1069

Merged
merged 6 commits into from
Feb 16, 2022
Merged

Stage 08 extensions and realms/logout #1069

merged 6 commits into from
Feb 16, 2022

Conversation

danlester
Copy link
Contributor

Fixes #1065

Changes:

  • Renamed stage 08 to 08-qhub-tf-extensions
  • Restored and simplified tf_extensions functionality
  • jupyterhub.overrides.hub.extraEnvs is merged with native qhub env vars (restored functionality)
  • Keycloak realm is called qhub again, not qhub-<project name> to simplify links
  • Logout functionality restored - i.e. JupyterHub logout also logs out of Keycloak (and other tf_extensions if present)

Note that existing recent dev deployments may struggle with the realm renaming, and of course will need stages to be cleared before re-rendering to avoid bugs like #1062

Types of changes

What types of changes does your code introduce?

Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • Yes
  • No

In case you checked yes, did you write tests?

  • Yes
  • No

@danlester danlester changed the title Tfexts2 Stage 08 extensions and realms/logout Feb 16, 2022
@danlester danlester added this to the Release v0.4.0 milestone Feb 16, 2022
@danlester danlester requested a review from costrouc February 16, 2022 19:26
Copy link
Member

@costrouc costrouc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me. I was able to deploy with this branch successfully. Thanks for the changes @danlester

# when Keycloak and JupyterHub are logged out
for ext in config.get("tf_extensions", []):
if ext.get("logout", "") != "":
final_logout_uri = "{}?{}".format(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering how to add this behaviour to conda-store. Awesome didn't think that logout could support a redirect allowing the user to do multiple logouts. Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Stage 08
2 participants