Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add panel-serve as a CDS dashboard option #1070

Merged
merged 7 commits into from
Jun 23, 2022
Merged

Add panel-serve as a CDS dashboard option #1070

merged 7 commits into from
Jun 23, 2022

Conversation

iameskild
Copy link
Member

@iameskild iameskild commented Feb 17, 2022

Fixes | Closes | Resolves #1284

Please remove anything marked as optional that you don't need to fill in. Choose one of the keywords preceding to refer to the issue this PR solves, followed by the issue number (e.g Fixes # 666). If there is no issue, remove the line. Remove this note after reading.

Changes:

New feature based on the work @pierrotsmnrd, @danlester and I worked on for recent client project.

Types of changes

What types of changes does your code introduce?

Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • Yes
  • No

In case you checked yes, did you write tests?

  • Yes
  • No

Further comments (optional)

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered and more.

@trallard trallard added the status: in progress 🏗 This task is currently being worked on label Feb 25, 2022
@costrouc
Copy link
Member

@iameskild what is the status of this PR? Is it ready for review

@iameskild
Copy link
Member Author

iameskild commented Feb 28, 2022

@costrouc I was gonna hold off merging since we were in a freeze prior to the v0.4.0 release but I wanted to get this in so that it would remind me to return to it later. The only thing that might be worth following up on is trying to make the timeout values configurable from the qhub-config.yaml. Is that something you think would be worthwhile? Otherwise, I'm happy to see this merged.

@magsol magsol added this to the Future Planning milestone Apr 26, 2022
@viniciusdc
Copy link
Contributor

@iameskild May we close this (as its currently a draft) and re-open once migrated to Nebari?

@iameskild
Copy link
Member Author

@viniciusdc I need to wrap up this PR this week. I might request your review when I get it finished :)

@iameskild iameskild marked this pull request as ready for review May 27, 2022 04:03
@iameskild iameskild requested a review from pierrotsmnrd May 27, 2022 04:04
@iameskild
Copy link
Member Author

@pierrotsmnrd this is ready for review. This will likely need to be tested on the beta-deployment to ensure that it works. Thanks for your patience :)

c.VariableMixin.proxy_ready_timeout = 600
c.VariableMixin.proxy_request_timeout = 600

userhome = f"/home/{os.getenv('JUPYTERHUB_USER', 'jovyan')}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this work? Since qhub not uses /home/<username>/

@dharhas
Copy link
Member

dharhas commented Jun 3, 2022

@iameskild @aktech Can we fix this and get it merged and deployed. I need it for a demo on Monday.

@trallard trallard added status: in review 👀 This PR is currently being reviewed by the team needs: changes 🧱 Review completed - some changes are needed before merging and removed status: in progress 🏗 This task is currently being worked on labels Jun 7, 2022
@iameskild
Copy link
Member Author

@costrouc I made some changes based on the concern you had. I tested this on minikube and I am able to successfully get the username and launch a panel-serve app 🙌 let me know if you have any other questions or concerns!

cc @pierrotsmnrd

@iameskild iameskild requested a review from costrouc June 20, 2022 21:39
@iameskild iameskild added area: integration/dashboards needs: review 👀 This PR is complete and ready for reviewing and removed needs: changes 🧱 Review completed - some changes are needed before merging needs: review 👀 This PR is complete and ready for reviewing status: in review 👀 This PR is currently being reviewed by the team labels Jun 20, 2022
Copy link
Member

@costrouc costrouc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome thanks for these changes @iameskild. This looks great to me.

@iameskild iameskild merged commit 38e427b into main Jun 23, 2022
@iameskild iameskild deleted the feat-panel-serve branch June 23, 2022 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: review 👀 This PR is complete and ready for reviewing
Projects
Development

Successfully merging this pull request may close these issues.

[ENH] - add a default panel-serve framework in CDSDashboards
7 participants