-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add panel-serve as a CDS dashboard option #1070
Conversation
@iameskild what is the status of this PR? Is it ready for review |
@costrouc I was gonna hold off merging since we were in a freeze prior to the v0.4.0 release but I wanted to get this in so that it would remind me to return to it later. The only thing that might be worth following up on is trying to make the timeout values configurable from the |
@iameskild May we close this (as its currently a draft) and re-open once migrated to Nebari? |
@viniciusdc I need to wrap up this PR this week. I might request your review when I get it finished :) |
@pierrotsmnrd this is ready for review. This will likely need to be tested on the beta-deployment to ensure that it works. Thanks for your patience :) |
c.VariableMixin.proxy_ready_timeout = 600 | ||
c.VariableMixin.proxy_request_timeout = 600 | ||
|
||
userhome = f"/home/{os.getenv('JUPYTERHUB_USER', 'jovyan')}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this work? Since qhub not uses /home/<username>/
@iameskild @aktech Can we fix this and get it merged and deployed. I need it for a demo on Monday. |
@costrouc I made some changes based on the concern you had. I tested this on minikube and I am able to successfully get the username and launch a panel-serve app 🙌 let me know if you have any other questions or concerns! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome thanks for these changes @iameskild. This looks great to me.
Fixes | Closes | Resolves #1284
Changes:
New feature based on the work @pierrotsmnrd, @danlester and I worked on for recent client project.
Types of changes
What types of changes does your code introduce?
Put an
x
in the boxes that applyTesting
Requires testing
In case you checked yes, did you write tests?
Further comments (optional)
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered and more.