Reorganizing render, deploy, destroy to unify stages input_vars, tf_objects, checks, and state_imports #1091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tf_objects, checks, and state_imports Closes #1081
danlester
approved these changes
Feb 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is only a refactor of render, deploy, and destroy. The motivation for this is allowing for the closing of #1081. In order to properly delete the aws ingress we need to be able to get the terraform outputs from some early kubernetes stages. This PR will also allow for the easier transition to #865.
There are no modifications to the behavior of the code.
Going into more detail about the heart of the issue:
For each stage we have to supply input variables, dymanic terraform objects, terraform imports.
We cannot run
terraform outputwithout supplying the proper input variables. Within deploy.py and destroy.py this was becoming repetative. Thus I've moved the definitions into astages/*.pydirectory which will need to be done with whatever extension mechanism we chose.