-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding tests for juypterhub-ssh, jhub-client, and vs code #1123
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Looks good, although would be good not to have to start/stop the JupyterLab server for every test - I guess we can work on that if we add extra tests such as for Dask Gateway. |
@danlester I agree. This would make the tests faster. But I don't know how we can get around this since in the UI tests we want to test the |
Yes, this was one reason I built the Python tests into Cypress initially - click to Start, then run the tests, then stop! But as long as multiple notebooks can be done in one session, maybe that's OK. |
Ah that makes perfect sense. The |
From my testing jupyterhub-ssh does not fully work as an expected ssh session. Currently it is hanging at times with
And then hanging and not giving a shell.