Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround for kubernetes-client version issue #1148

Merged
merged 1 commit into from
Mar 7, 2022
Merged

Conversation

iameskild
Copy link
Member

Fixes | Closes | Resolves #1147

Please remove anything marked as optional that you don't need to fill in.
Choose one of the keywords preceding to refer to the issue this PR solves, followed by the issue number (e.g Fixes # 666).
If there is no issue, remove the line. Remove this note after reading.

Changes introduced in this PR:

  • Use list_namespace() instead of list_node() as a means of checking the kubernetes cluster created in stage 02 is up and running.

Types of changes

What types of changes does your PR introduce?

Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • Yes
  • No

In case you checked yes, did you write tests?

  • Yes
  • No

Documentation

Does your contribution include breaking changes or deprecations?
If so have you updated the documentation?

  • Yes, docstrings
  • Yes, main documentation
  • Yes, deprecation notices

Further comments (optional)

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered and more.

@iameskild iameskild added this to the Release v0.4.0 milestone Mar 7, 2022
@iameskild iameskild added the type: bug 🐛 Something isn't working label Mar 7, 2022
@iameskild iameskild requested a review from costrouc March 7, 2022 10:41
@iameskild
Copy link
Member Author

@costrouc costrouc merged commit 3fc25e3 into main Mar 7, 2022
@costrouc costrouc deleted the 20220307eae branch March 7, 2022 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug 🐛 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] - kubernetes-client latest version breaks 02-infrastructure
2 participants