Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate kbatch #1258

Merged
merged 19 commits into from
May 26, 2022
Merged

Integrate kbatch #1258

merged 19 commits into from
May 26, 2022

Conversation

iameskild
Copy link
Member

@iameskild iameskild commented Apr 22, 2022

Fixes | Closes | Resolves #

Please remove anything marked as optional that you don't need to fill in.
Choose one of the keywords preceding to refer to the issue this PR solves, followed by the issue number (e.g Fixes # 666).
If there is no issue, remove the line. Remove this note after reading.

Changes introduced in this PR:

Types of changes

What types of changes does your PR introduce?

Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • Yes
  • No

In case you checked yes, did you write tests?

  • Yes
  • No

Documentation

Does your contribution include breaking changes or deprecations?
If so have you updated the documentation?

  • Yes, docstrings
  • Yes, main documentation
  • Yes, deprecation notices

Further comments (optional)

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered and more.

TODO:

  • Finish integrating dask-gateway
  • Enable kbatch to run in insecure mode (no SSL cert)
  • Add overrides mapping
  • Add documentation

cc @Adam-D-Lewis @costrouc

@magsol magsol added this to the Future Planning milestone Apr 26, 2022
@iameskild iameskild marked this pull request as ready for review April 26, 2022 20:37
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@iameskild iameskild requested a review from costrouc May 3, 2022 01:48
@iameskild
Copy link
Member Author

@costrouc @Adam-D-Lewis I think this PR is ready for a final review :)

@costrouc costrouc merged commit 0a0de22 into main May 26, 2022
@costrouc costrouc deleted the kbatch branch May 26, 2022 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants