Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release-checklist issue template #1314

Merged
merged 3 commits into from
Jun 30, 2022
Merged

Add release-checklist issue template #1314

merged 3 commits into from
Jun 30, 2022

Conversation

iameskild
Copy link
Member

Related to nebari-dev/governance#2

Please remove anything marked as optional that you don't need to fill in.
Choose one of the keywords preceding to refer to the issue this PR solves, followed by the issue number (e.g Fixes # 666).
If there is no issue, remove the line. Remove this note after reading.

Changes introduced in this PR:

  • Enables maintainers to easily create a release checklist that can guide them through the release process.

Types of changes

What types of changes does your PR introduce?

Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • Yes
  • No

In case you checked yes, did you write tests?

  • Yes
  • No

Documentation

Does your contribution include breaking changes or deprecations?
If so have you updated the documentation?

  • Yes, docstrings
  • Yes, main documentation
  • Yes, deprecation notices

Further comments (optional)

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered and more.

@viniciusdc viniciusdc added the needs: review 👀 This PR is complete and ready for reviewing label Jun 14, 2022
Copy link
Member

@trallard trallard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - except for the redundancy on having "two" release checklists - need to agree on a single source of truth

@trallard trallard added needs: changes 🧱 Review completed - some changes are needed before merging and removed needs: review 👀 This PR is complete and ready for reviewing labels Jun 15, 2022
@iameskild iameskild requested a review from trallard June 20, 2022 23:58
@iameskild iameskild added needs: review 👀 This PR is complete and ready for reviewing and removed needs: changes 🧱 Review completed - some changes are needed before merging labels Jun 20, 2022
@iameskild
Copy link
Member Author

Hi @trallard I've added the testing checklist issue template and updated the docs to point to reference these checklist templates. Let me know if you have any other feedback :)

Copy link
Member

@trallard trallard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@trallard trallard merged commit d9a8dbb into main Jun 30, 2022
@trallard trallard deleted the release_checklist branch June 30, 2022 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:developer-experience 👩🏻‍💻 area: documentation 📖 Improvements or additions to documentation needs: review 👀 This PR is complete and ready for reviewing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants