Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.4.2 release notes #1323

Merged
merged 9 commits into from
Jun 9, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 37 additions & 1 deletion RELEASE.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,42 @@ ______________________________________________________________________

### Bug fixes


## Release v0.4.2 - June 8. 2022

### Incident postmortem

#### Bitnami update breaks post v0.4.0 releases

On June 2, 2022, GitHub user @peytondmurray reported [issue 1306](https://github.com/Quansight/qhub/issues/1306), stating that he was unable to deploy QHub using either the latest release `v0.4.1` or installing `qhub` from `main`. As verified by @peytondmurray and others, during your first `qhub deploy`, the deployment halts and complains about two invalid Helm charts missing from the bitnami `index.yaml`.

[Bitnami's decision to update how long they keep old Helm charts in their index for](https://github.com/bitnami/charts/issues/10539) has essentially broken all post `v0.4.0` versions of QHub.

This is a severe bug that will affect any new user who tries to install and deploy QHub with any version less than `v0.4.2` and greater than or equal to `v0.4.0`.

Given the impact and severity of this bug, the team has decided to quickly cut a hotfix.

#### AWS deployment failing due to old auto-scaler helm chart

On May 27, 2022, GitHub user @tylerpotts reported [issue 1302](https://github.com/Quansight/qhub/issues/1302), stating that he was unable to deploy QHub using the latest release `v0.4.1` (or installing `qhub` from `main`). As described in the original issue, the deployment failed complaining about the deprecated `v1beta` Kubernetes API. This led to the discovery that we were using an outdated `cluster_autoscaler` helm chart.

The solution is to update from `v1beta` to `v1` Kubernetes API for the appropriate resources and update the reference to the `cluster_autoscaler` helm chart.

Given the impact and severity of this bug, the team has decided to quickly cut a hotfix.

### Bug fixes

This release is a hotfix for the issue summarized in the following:
* [issue 1319](https://github.com/Quansight/qhub/issues/1319)
* [issue 1306](https://github.com/Quansight/qhub/issues/1306)
* [issue 1302](https://github.com/Quansight/qhub/issues/1302)


### What's Changed
iameskild marked this conversation as resolved.
Show resolved Hide resolved
* Update minio, postgresql chart repo location by @iameskild in [PR 1308](https://github.com/Quansight/qhub/pull/1308)
* Fix broken AWS, set minimum desired size to 1, enable 0 scaling by @tylerpotts in [PR 1304](https://github.com/Quansight/qhub/issues/1304)


## Release v0.4.1 - May 10. 2022

### Feature changes and enhancements
Expand Down Expand Up @@ -161,7 +197,7 @@ Explicit user facing changes:
- Pin terraform providers by @Adam-D-Lewis in https://github.com/Quansight/qhub/pull/914
- qhub-config.yaml as a secret by @danlester in https://github.com/Quansight/qhub/pull/905
- Setup/Add integration/deployment tests via pytest by @aktech in https://github.com/Quansight/qhub/pull/922
- Disabl/Remove the stale bot by @viniciusdc in https://github.com/Quansight/qhub/pull/923
- Disable/Remove the stale bot by @viniciusdc in https://github.com/Quansight/qhub/pull/923
- Integrates Hadolint for Dockerfile linting by @HarshCasper in https://github.com/Quansight/qhub/pull/917
- Reduce minimum nodes in user and dask node pools to 0 for Azure / GCP by @tarundmsharma in https://github.com/Quansight/qhub/pull/723
- Allow jupyterhub.overrides in qhub-config.yaml by @danlester in https://github.com/Quansight/qhub/pull/930
Expand Down
2 changes: 1 addition & 1 deletion qhub/stages/input_vars.py
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ def stage_02_infrastructure(stage_outputs, config):
{
"name": key,
"min_size": value["min_nodes"],
"desired_size": value["min_nodes"],
"desired_size": max(value["min_nodes"], 1),
"max_size": value["max_nodes"],
"gpu": value.get("gpu", False),
"instance_type": value["instance"],
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@ resource "helm_release" "autoscaler" {
name = "cluster-autoscaler"
namespace = var.namespace

repository = "https://charts.helm.sh/stable"
repository = "https://kubernetes.github.io/autoscaler"
chart = "cluster-autoscaler"
version = "7.1.0"
version = "9.19.0"

values = concat([
jsonencode({
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ resource "kubernetes_manifest" "job_extcr_cred_updater" {

resource "kubernetes_manifest" "cronjob_extcr_cred_updater" {
manifest = {
"apiVersion" = "batch/v1beta1"
"apiVersion" = "batch/v1"
"kind" = "CronJob"
"metadata" = {
"name" = "extcr-cred-updater"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ resource "helm_release" "minio" {
name = "${var.name}-minio"
namespace = var.namespace

repository = "https://charts.bitnami.com/bitnami"
repository = "https://raw.githubusercontent.com/bitnami/charts/defb094c658024e4aa8245622dab202874880cbc/bitnami"
chart = "minio"
# last release that was Apache-2.0
version = "6.7.4"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ resource "helm_release" "postgresql" {
name = "${var.name}-postgresql"
namespace = var.namespace

repository = "https://charts.bitnami.com/bitnami"
repository = "https://raw.githubusercontent.com/bitnami/charts/defb094c658024e4aa8245622dab202874880cbc/bitnami"
chart = "postgresql"
version = "10.13.12"

Expand Down