-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump qhub-dask version to 0.4.3 #1341
Conversation
OK. Some steps here:
> [dask-worker 9/11] RUN /opt/scripts/install-conda-environment.sh /opt/dask-worker/environment.yaml 'false':
#30 25.90
#30 25.90 Encountered problems while solving:
#30 25.90 - nothing provides requested qhub-dask 0.4.3
profiles:
dask_worker:
"Small Worker":
worker_cores_limit: 1
worker_cores: 1
worker_memory_limit: 1G
worker_memory: 1G
image: "quansight/qhub-dask-worker:bump..." you can create a copy of the above profile like "dask-worker-updated" if you don't want to affect the global environment; |
5ef4270
to
f7b31d8
Compare
Merging is delayed because qhub-dask 0.4.3 must either choose to
|
Action plan - drop 3.7 -> push to QHub beta and see how that works out |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested this, and everything seems to be working -- will check again on Monday to be sure.
...template/stages/07-kubernetes-services/modules/kubernetes/services/dask-gateway/variables.tf
Show resolved
Hide resolved
It seems that the current scheduler is still using an outdated version, @costrouc how do we pass over the `cluster-image var to the gateway deployments? (I was able to find for worker/gateway, but not sure about the above), is it in here: c.KubeClusterConfig.image = (
f"{config['cluster-image']['name']}:{config['cluster-image']['tag']}" Also, I found config for dask that we can use as well, is this worth it? # backend nested configuration relates to the scheduler and worker resources
# created for DaskCluster k8s resources by the controller.
backend:
# The image to use for both schedulers and workers.
image:
name: ghcr.io/dask/dask-gateway
tag: "set-by-chartpress"
pullPolicy: IfNotPresent |
@costrouc can you please follow up on this issue? |
Oh, silly me! I was using the wrong environment for testing. Thanks, @costrouc and @peytondmurray, all seem okay now 😄 Just to keep a record of the test here: the version outputs: client = cluster.get_client()
client.get_versions()
{'scheduler': {'host': {'python': '3.9.13.final.0',
'python-bits': 64,
'OS': 'Linux',
'OS-release': '5.10.90+',
'machine': 'x86_64',
'processor': 'x86_64',
'byteorder': 'little',
'LC_ALL': 'None',
'LANG': 'None'},
'packages': {'python': '3.9.13.final.0',
'dask': '2022.04.2',
'distributed': '2022.4.2',
'msgpack': '1.0.4',
'cloudpickle': '2.1.0',
'tornado': '6.1',
'toolz': '0.11.2',
'numpy': '1.23.0',
'pandas': '1.4.3',
'lz4': '4.0.0'}},
'workers': {'tls://10.48.1.24:40695': {'host': {'python': '3.9.13.final.0',
'python-bits': 64,
'OS': 'Linux',
'OS-release': '5.10.90+',
'machine': 'x86_64',
'processor': 'x86_64',
'byteorder': 'little',
'LC_ALL': 'None',
'LANG': 'None'},
'packages': {'python': '3.9.13.final.0',
'dask': '2022.04.2',
'distributed': '2022.4.2',
'msgpack': '1.0.4',
'cloudpickle': '2.1.0',
'tornado': '6.1',
'toolz': '0.11.2',
'numpy': '1.23.0',
'pandas': '1.4.3',
'lz4': '4.0.0'}}},
'client': {'host': {'python': '3.9.13.final.0',
'python-bits': 64,
'OS': 'Linux',
'OS-release': '5.10.90+',
'machine': 'x86_64',
'processor': 'x86_64',
'byteorder': 'little',
'LC_ALL': 'C.UTF-8',
'LANG': 'C.UTF-8'},
'packages': {'python': '3.9.13.final.0',
'dask': '2022.04.2',
'distributed': '2022.4.2',
'msgpack': '1.0.4',
'cloudpickle': '2.1.0',
'tornado': '6.1',
'toolz': '0.11.2',
'numpy': '1.23.0',
'pandas': '1.4.3',
'lz4': '4.0.0'}}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, next is updating the docs and closing the PR open for qhub-dask
to undo the latest changes.
Closes #1296
Changes introduced in this PR:
qhub-dask
to version0.4.3
, which includesdistributed==2022.04.2
anddask-gateway==2022.4.0
Types of changes
Testing
Requires testing
In case you checked yes, did you write tests?
Github workflows for testing new versions of qhub-dask before they get released to conda-forge will be addressing in #1339. Until then, testing was carried out on an existing qhub deployment, see the discussion at conda-forge/qhub-dask-feedstock#14 for more information.
Documentation
Does your contribution include breaking changes or deprecations?
If so have you updated the documentation?