Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add backwards compatibility item to test checklist #1381

Merged
merged 1 commit into from
Jul 27, 2022

Conversation

viniciusdc
Copy link
Contributor

Changes introduced in this PR:

  • Add a new item to the testing checklist to validate if the current version of qhub loads the previous YAML config and if the required upgrade config was added.

Types of changes

What types of changes does your PR introduce?

Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe): issue templating update

Further comments (optional)

This might require an extra issue for further discussion as to how we should keep track of the necessary changes required to include in the upgrade command.

@viniciusdc viniciusdc requested a review from iameskild July 27, 2022 17:48
Copy link
Member

@iameskild iameskild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks @viniciusdc :)

@viniciusdc viniciusdc merged commit 3144482 into main Jul 27, 2022
@iameskild iameskild deleted the backwards-compatibility-check branch July 27, 2022 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants