Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Add pyarrow and s3fs #1393

Merged
merged 3 commits into from
Aug 12, 2022
Merged

[ENH] Add pyarrow and s3fs #1393

merged 3 commits into from
Aug 12, 2022

Conversation

viniciusdc
Copy link
Contributor

Related to #1359

Changes introduced in this PR:

  • Add two new packages to Dask env, pyarrow and s3fs

Types of changes

What types of changes does your PR introduce?

Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • Yes
  • No

In case you checked yes, did you write tests?

  • Yes
  • No

Documentation

Does your contribution include breaking changes or deprecations?
If so have you updated the documentation?

  • Yes, docstrings
  • Yes, main documentation
  • Yes, deprecation notices

Further comments (optional)

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered and more.

Copy link
Member

@iameskild iameskild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)

I wonder if it's also worth adding gcsfs, what do you think?

@viniciusdc
Copy link
Contributor Author

Looks good to me :)

I wonder if it's also worth adding gcsfs, what do you think?

If we add s3sf I don't see a problem, though to be honest I would prefer to keep s3fs and gcsfs as something the user should add to a personal env based on filesystem/dask. The reason is, that dask should be the basic env for running dask operations, anything outside this should go to a user/group-based env.

qhub/initialize.py Outdated Show resolved Hide resolved
@viniciusdc viniciusdc requested a review from iameskild August 12, 2022 18:27
@iameskild iameskild merged commit 514d52a into main Aug 12, 2022
@iameskild iameskild deleted the update-dask-env branch August 12, 2022 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants