Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add project name to jhub helm chart release name #1422

Merged
merged 2 commits into from
Sep 1, 2022
Merged

Conversation

iameskild
Copy link
Member

@iameskild iameskild commented Aug 29, 2022

Fixes | Closes | Resolves #1418

Please remove anything marked as optional that you don't need to fill in.
Choose one of the keywords preceding to refer to the issue this PR solves, followed by the issue number (e.g Fixes # 666).
If there is no issue, remove the line. Remove this note after reading.

Changes introduced in this PR:

  • Updates the jupyterhub helm chart release name to include the project name.
    • This has been tested on new and existing deployments (no breaking change)

Types of changes

What types of changes does your PR introduce?

Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • Yes
  • No

In case you checked yes, did you write tests?

  • Yes
  • No

Documentation

Does your contribution include breaking changes or deprecations?
If so have you updated the documentation?

  • Yes, docstrings
  • Yes, main documentation
  • Yes, deprecation notices

Further comments (optional)

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered and more.

@iameskild iameskild added this to the Release v0.4.4 milestone Aug 29, 2022
@iameskild iameskild changed the title Add project name to jhub helm chart name Add project name to jhub helm chart release name Aug 29, 2022
@viniciusdc
Copy link
Contributor

@iameskild did you test with local? just to make sure that we don't have this hardcoded anywhere else.

Copy link
Member

@costrouc costrouc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iameskild could we use the namespace instead?

Also could you check the name of the cluster-role that is produced after this is applied.

@iameskild
Copy link
Member Author

@costrouc @viniciusdc thanks for the feedback. I did test this locally and on an existing deployment. The cluster-role name was also updated 👍

@iameskild iameskild requested a review from costrouc September 1, 2022 01:38
@costrouc costrouc merged commit 4d4b1d0 into main Sep 1, 2022
@iameskild iameskild deleted the name_update_1418 branch September 20, 2022 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update terraform scripts to improve deployment
3 participants