Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add properties to middleware crd headers #1434

Merged
merged 2 commits into from
Sep 13, 2022
Merged

Add properties to middleware crd headers #1434

merged 2 commits into from
Sep 13, 2022

Conversation

iameskild
Copy link
Member

@iameskild iameskild commented Sep 13, 2022

Fixes | Closes | Resolves #

Please remove anything marked as optional that you don't need to fill in.
Choose one of the keywords preceding to refer to the issue this PR solves, followed by the issue number (e.g Fixes # 666).
If there is no issue, remove the line. Remove this note after reading.

Changes introduced in this PR:

  • Add the ability to add headers to traefik middleware

Types of changes

What types of changes does your PR introduce?

Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • Yes
  • No

In case you checked yes, did you write tests?

  • Yes
  • No

Documentation

Does your contribution include breaking changes or deprecations?
If so have you updated the documentation?

  • Yes, docstrings
  • Yes, main documentation
  • Yes, deprecation notices

Further comments (optional)

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered and more.

@iameskild iameskild requested a review from costrouc September 13, 2022 15:05
@iameskild iameskild added type: maintenance 🛠 Day-to-day maintenance tasks area: k8s ⎈ labels Sep 13, 2022
@costrouc costrouc merged commit 77265d8 into main Sep 13, 2022
@costrouc costrouc deleted the traefik_crd_updates branch September 13, 2022 17:40
@iameskild iameskild added this to the Release v0.4.4 milestone Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: k8s ⎈ type: maintenance 🛠 Day-to-day maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants