Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fix, enhancements and pytests for CLI #1498

Merged
merged 6 commits into from
Oct 27, 2022
Merged

Add fix, enhancements and pytests for CLI #1498

merged 6 commits into from
Oct 27, 2022

Conversation

iameskild
Copy link
Member

Fixes | Closes | Resolves # Related to #1478

Please remove anything marked as optional that you don't need to fill in.
Choose one of the keywords preceding to refer to the issue this PR solves, followed by the issue number (e.g Fixes # 666).
If there is no issue, remove the line. Remove this note after reading.

Changes introduced in this PR:

Types of changes

What types of changes does your PR introduce?

Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • Yes
  • No

In case you checked yes, did you write tests?

  • Yes
  • No

Documentation

Does your contribution include breaking changes or deprecations?
If so have you updated the documentation?

  • Yes, docstrings
  • Yes, main documentation
  • Yes, deprecation notices

Further comments (optional)

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered and more.

@iameskild iameskild changed the base branch from main to release/2022.10.1 October 20, 2022 04:04
@iameskild
Copy link
Member Author

Blocked by #1501

@iameskild iameskild changed the title [wip] Add fix, enhancements and pytests for CLI Add fix, enhancements and pytests for CLI Oct 20, 2022
@iameskild iameskild added this to the 🪴 Nebari rename milestone Oct 26, 2022
@viniciusdc
Copy link
Contributor

@iameskild is this ready for review?

@iameskild
Copy link
Member Author

@trallard @viniciusdc @aktech this PR is ready for review.

We currently still have the old CLI in the codebase, it think we can remove it in another PR, what are your thoughts?

@viniciusdc
Copy link
Contributor

viniciusdc commented Oct 27, 2022 •
edited
Loading

@iameskild silly request here, but can we modify the name of this test to PyTest & Formatting? It took me a while to find where pytest was running...
https://github.com/nebari-dev/nebari/actions/runs/3336080683/workflow#L30

@viniciusdc viniciusdc mentioned this pull request Oct 27, 2022
Closed
2 tasks
@iameskild
Copy link
Member Author

@viniciusdc I ended up just removing the black and flake8 steps since both of these are being called in the pre-commit action. How does that work for you?

viniciusdc
viniciusdc approved these changes Oct 27, 2022
View reviewed changes
Copy link
Contributor

@viniciusdc viniciusdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic!! thanks @iameskild

@viniciusdc viniciusdc merged commit 72d855a into release/2022.10.1 Oct 27, 2022
@iameskild iameskild deleted the enh_cli branch October 27, 2022 15:34
iameskild added a commit that referenced this pull request Nov 2, 2022
@iameskild @pavithraes
@viniciusdc @trallard @FFY00 @aktech @nebari-sensei
Release/2022.10.1 (#1527)
788aae8 
* Switch to CalVer (#1501)

* Run CI on branchs release/**

* Update pyproject.toml to use calver

* Update on branch

* Update theme welcome messages to use Nebari (#1503)

* update welcome messge

* remove qhub specifics from theme

* Name change QHub --> Nebari (#1508)

* Name change: .github

* Name change: qhub/

* Name change: tests/

* Name change: tests_deployment/

* Name change: tests_e2e/

* Name change: /

* Rename folder

* Rename releases

* Remove qhub/

* Run pre-commit

* Revert docs links

* Fix infracost artifact names

* Update upgrade command + test

* Updates based on review

* Update step output format

* Fix: Update step output format

* Update nebari/provider/cicd/common.py

Co-authored-by: Tania Allard <taniar.allard@gmail.com>

* Update stage 08 folder names

* Update nebari/schema.py

Co-authored-by: Tania Allard <taniar.allard@gmail.com>

* Update nebari/template/stages/02-infrastructure/azure/variables.tf

Co-authored-by: Tania Allard <taniar.allard@gmail.com>

* Update nebari/template/stages/02-infrastructure/do/variables.tf

Co-authored-by: Tania Allard <taniar.allard@gmail.com>

* Update nebari/template/stages/02-infrastructure/gcp/variables.tf

Co-authored-by: Tania Allard <taniar.allard@gmail.com>

* Update nebari/template/stages/02-infrastructure/gcp/variables.tf

Co-authored-by: Tania Allard <taniar.allard@gmail.com>

* Update nebari/template/stages/03-kubernetes-initialize/variables.tf

Co-authored-by: Tania Allard <taniar.allard@gmail.com>

* Update nebari/template/stages/05-kubernetes-keycloak/variables.tf

Co-authored-by: Tania Allard <taniar.allard@gmail.com>

* Update nebari/template/stages/06-kubernetes-keycloak-configuration/variables.tf

Co-authored-by: Tania Allard <taniar.allard@gmail.com>

* Update nebari/template/stages/06-kubernetes-keycloak-configuration/variables.tf

Co-authored-by: Tania Allard <taniar.allard@gmail.com>

* Update nebari/template/stages/07-kubernetes-services/modules/kubernetes/forwardauth/variables.tf

Co-authored-by: Tania Allard <taniar.allard@gmail.com>

* Update setup.cfg

Co-authored-by: Tania Allard <taniar.allard@gmail.com>

* Update scripts/aws-force-destroy.py

Co-authored-by: Tania Allard <taniar.allard@gmail.com>

* Update setup.cfg

Co-authored-by: Tania Allard <taniar.allard@gmail.com>

* Update setup.cfg

Co-authored-by: Tania Allard <taniar.allard@gmail.com>

* Update setup.cfg

Co-authored-by: Tania Allard <taniar.allard@gmail.com>

* Update setup.cfg

Co-authored-by: Tania Allard <taniar.allard@gmail.com>

* Update nebari/constants.py

Co-authored-by: Vinicius D. Cerutti <51954708+viniciusdc@users.noreply.github.com>

* Update setup.cfg

Co-authored-by: Tania Allard <taniar.allard@gmail.com>

* fix flake8 complaint

* Update ref to qhub-dask to nebari-dask

* Update readme

* Change to PYPI_API_TOKEN

Co-authored-by: viniciusdc <vinivdc2009@hotmail.com>
Co-authored-by: Tania Allard <taniar.allard@gmail.com>
Co-authored-by: Vinicius D. Cerutti <51954708+viniciusdc@users.noreply.github.com>

* qhub/initialize: lazy load attributes that require remote information (#1509)

* qhub/initialize: lazy load attributes that require remote information

* Fix broken configuration

* fix renaming

* fix header text

* Update nebari/initialize.py

* Update nebari/initialize.py

* Blackify

Co-authored-by: Amit Kumar <dtu.amit@gmail.com>
Co-authored-by: Nebari-sensei <116370392+nebari-sensei@users.noreply.github.com>

* Update README logo (#1514)

* Add fix, enhancements and pytests for CLI (#1498)

* Add fix, enhancements and pytests for CLI

* No zero-padded month for CalVer release branches

* Update cli test

* Simplify test.yaml

* Remove old CLI + cleanup (#1519)

* Remove old cli

* Update theme

* Remove shim

* display_version: True

* Update `skip_remote_state_provision` default value (#1521)

* Add release notes for 2022.10.1 (#1523)

* Add release notes for 2022.10.1

* Wording

* Update README.md with new docs links

* Update README.md with new docs links

Co-authored-by: Vinicius D. Cerutti <51954708+viniciusdc@users.noreply.github.com>

* Remove leading `v` for release action (#1526)

* Remove leading v for release tags

* Add note to release checklist

* Merge release branch into main

Co-authored-by: Pavithra Eswaramoorthy <pavithraes@outlook.com>
Co-authored-by: viniciusdc <vinivdc2009@hotmail.com>
Co-authored-by: Tania Allard <taniar.allard@gmail.com>
Co-authored-by: Vinicius D. Cerutti <51954708+viniciusdc@users.noreply.github.com>
Co-authored-by: Filipe Laíns <filipe.lains@gmail.com>
Co-authored-by: Amit Kumar <dtu.amit@gmail.com>
Co-authored-by: Nebari-sensei <116370392+nebari-sensei@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viniciusdc viniciusdc viniciusdc approved these changes

@trallard trallard Awaiting requested review from trallard

@aktech aktech Awaiting requested review from aktech

Assignees
No one assigned
Labels
area: nebari-cli type: enhancement 💅🏼 New feature or request
Projects
None yet
Milestone
🪴 Nebari rename
Development

Successfully merging this pull request may close these issues.
2 participants
@iameskild @viniciusdc