Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update theme welcome messages to use Nebari #1499

Closed
wants to merge 1 commit into from
Closed

Update theme welcome messages to use Nebari #1499

wants to merge 1 commit into from

Conversation

pavithraes
Copy link
Member

@pavithraes pavithraes commented Oct 18, 2022

Fixes | Closes | Resolves #1390

Changes introduced in this PR:

  • Updated messaging for Nebari

Types of changes

What types of changes does your PR introduce?

Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • Yes
  • No

@pavithraes pavithraes marked this pull request as ready for review October 18, 2022 18:37
Copy link
Member

@trallard trallard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - only note is if we intentionally dropped the {qhub_domain} well nebari on purpose?

@trallard
Copy link
Member

Also do we need to change the target branch to release/2022.10.1?

@pavithraes
Copy link
Member Author

pavithraes commented Oct 19, 2022

Thanks for the review!

only note is if we intentionally dropped the {qhub_domain} well nebari on purpose?

I did drop that on purpose. I figured since users have already navigated to the domain, we don't provide new information by displaying it, but let me know if we want to add it back!

Also do we need to change the target branch to release/2022.10.1?

Oh, shall do!

@pavithraes pavithraes changed the base branch from main to release/2022.10.1 October 19, 2022 18:39
@pavithraes pavithraes closed this by deleting the head repository Oct 21, 2022
@pavithraes
Copy link
Member Author

Oops, I didn't even realize it. I'll open a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement 💅🏼 New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ENH] - Update theme Welcome message
2 participants