Update links to Nebari docs in guided init #1557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* 🔄 Synced local '.github/ISSUE_TEMPLATE/' with remote '.github/ISSUE_TEMPLATE/' MAINT - Sync .github files 🤖 * 🔄 Synced local 'LICENSE' with remote 'LICENSE' MAINT - Sync .github files 🤖 * 🔄 Synced local 'CONTRIBUTING.md' with remote 'CONTRIBUTING.md' MAINT - Sync .github files 🤖 * 🔄 Synced local '.github/ISSUE_TEMPLATE/bug-report.yml' with remote '.github/ISSUE_TEMPLATE/bug-report-nebari.yml' MAINT - Sync .github files 🤖 * 🔄 Synced local '.github/PULL_REQUEST_TEMPLATE.md' with remote '.github/PULL_REQUEST_TEMPLATE_simple.md' MAINT - Sync .github files 🤖 Co-authored-by: nebari-sensei <null>
MAINT - Sync .github files 🤖 Co-authored-by: nebari-sensei <null>
* 🔄 Synced local '.github/ISSUE_TEMPLATE/' with remote '.github/ISSUE_TEMPLATE/' MAINT - Sync .github files 🤖 * 🔄 Synced local 'CONTRIBUTING.md' with remote 'CONTRIBUTING.md' MAINT - Sync .github files 🤖 Co-authored-by: nebari-sensei <null>
pavithraes
added
type: bug 🐛
iameskild
reviewed
Nov 20, 2022
There was a problem hiding this comment.
Hi @pavithraes, is some of this work related to the update to nebari-dev/.github? Does one take precedence over another?
This was a side of effect of changing the branch the PR is merging into.
|
Hi @pavithraes, thanks for this update! I will circle back to this PR once we have settled on the gitflow workflow we want to use 👍 |
trallard
approved these changes
Nov 22, 2022
There was a problem hiding this comment.
This looks good to me - though we will need to change the target branch cc/ @iameskild so that we add these in the next release
trallard
added
the
needs: follow-up 📫
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues or PRs
Closes #1535
What does this implement/fix?
Put a
xin the boxes that applyTesting
Any other comments?