Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make conda-store file system read-only by default #1595

Merged
merged 2 commits into from
Dec 15, 2022
Merged

Make conda-store file system read-only by default #1595

merged 2 commits into from
Dec 15, 2022

Conversation

alimanfoo
Copy link
Contributor

This a small suggestion, but I'd suggest making the conda-store file system read-only by default. This will prevent users accidentally modifying environments created via conda-store by running pip install or conda install from their server.

@pavithraes
Copy link
Member

pavithraes commented Dec 9, 2022 •
edited
Loading

@alimanfoo Thanks for opening this PR! I've triggered the tests, and I think @iameskild or @costrouc can share more comments. :)

@pavithraes pavithraes requested a review from iameskild December 9, 2022 12:59
@pavithraes pavithraes added type: enhancement 💅🏼 New feature or request needs: review 👀 This PR is complete and ready for reviewing area: integration/conda-store status: in review 👀 This PR is currently being reviewed by the team and removed needs: review 👀 This PR is complete and ready for reviewing labels Dec 9, 2022
@pavithraes
Copy link
Member

/bot run tests

@github-actions
Copy link

github-actions bot commented Dec 9, 2022

Contributor Tests Triggered by @pavithraes

@pavithraes pavithraes requested a review from costrouc December 9, 2022 13:02
@iameskild
Copy link
Member

/bot run tests

@iameskild iameskild changed the base branch from release/2022.11.1 to develop December 13, 2022 00:45
@iameskild iameskild changed the base branch from develop to release/2022.11.1 December 13, 2022 00:46
@iameskild iameskild changed the base branch from release/2022.11.1 to develop December 13, 2022 00:56
iameskild
iameskild approved these changes Dec 13, 2022
View reviewed changes
Copy link
Member

@iameskild iameskild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested this on an existing deployment and I didn't run into any issues. I created a few new conda-store envs and had no trouble using them.

@costrouc do you have any objection to merging this?

@pavithraes pavithraes added status: approved 💪🏾 This PR has been reviewed and approved for merge and removed status: in review 👀 This PR is currently being reviewed by the team labels Dec 13, 2022
costrouc
costrouc approved these changes Dec 13, 2022
View reviewed changes
Copy link
Member

@costrouc costrouc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iameskild look great to me and ready for merge!

@iameskild iameskild merged commit 4607d1c into nebari-dev:develop Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iameskild iameskild iameskild approved these changes

@costrouc costrouc costrouc approved these changes

Assignees
No one assigned
Labels
area: integration/conda-store status: approved 💪🏾 This PR has been reviewed and approved for merge type: enhancement 💅🏼 New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alimanfoo @pavithraes @iameskild @costrouc