Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH - Switch to ruff and pre-commit.ci #1602

Merged
merged 4 commits into from
Dec 15, 2022
Merged

Conversation

trallard
Copy link
Member

@trallard trallard commented Dec 14, 2022

This PR adds the following changes:

  • Drop flake8 in favour of ruff
  • Moves ruff configurations to pyproject.toml
  • Enables pre-commit.ci for autoupdates and lining in PRs
  • Removes pre-commit GitHub action in favour of pre-commit.ci: note that the terraform_fmt cannot be run in pre-commit.ci so this will run in GH actions anyway

Reference Issues or PRs

Closes gh-1589

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

@trallard trallard added type: enhancement 💅🏼 New feature or request needs: review 👀 This PR is complete and ready for reviewing area: CI/CD 👷🏽‍♀️ area: dependencies 📦 All things dependencies labels Dec 14, 2022
@trallard trallard changed the title 🔧 Add pre-commit ci configuration ENH - Switch to ruff and pre-commit.ci Dec 14, 2022
@trallard trallard requested a review from iameskild December 14, 2022 16:40
Copy link
Member

@iameskild iameskild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks @trallard 💯

.pre-commit-config.yaml Show resolved Hide resolved
@trallard trallard added status: approved 💪🏾 This PR has been reviewed and approved for merge and removed needs: review 👀 This PR is complete and ready for reviewing labels Dec 15, 2022
@trallard trallard merged commit 0010968 into develop Dec 15, 2022
@trallard trallard deleted the trallard/pre-commit-ci branch December 15, 2022 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: CI/CD 👷🏽‍♀️ area: dependencies 📦 All things dependencies status: approved 💪🏾 This PR has been reviewed and approved for merge type: enhancement 💅🏼 New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MAINT - Replace flake8 with ruff
2 participants