Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure Argo-Workflow controller containerRuntimeExecutor is set to emissary #1614

Merged
merged 1 commit into from
Jan 10, 2023

Conversation

iameskild
Copy link
Member

@iameskild iameskild commented Jan 6, 2023

Reference Issues or PRs

Fixes #1573

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

@iameskild iameskild changed the title Ensure containerRuntimeExecutor is set to emissary Ensure Argo-Workflow controller containerRuntimeExecutor is set to emissary Jan 6, 2023
@iameskild iameskild added this to the Release 2023.1.1 milestone Jan 10, 2023
Copy link
Member

@costrouc costrouc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for the detailed issue makes sense what the issue was with the workflow engine. I see https://argoproj.github.io/argo-workflows/workflow-executors/#emissary-emissary which was descriptive

@trallard trallard added the status: approved 💪🏾 This PR has been reviewed and approved for merge label Jan 10, 2023
@iameskild iameskild merged commit 4bb3dcd into develop Jan 10, 2023
@iameskild iameskild deleted the fix-1573 branch January 10, 2023 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: integration/Argo status: approved 💪🏾 This PR has been reviewed and approved for merge type: bug 🐛 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] - Argo-Workflow pods linger after completed workflows on GCP
3 participants