Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set GKE release_channel to unspecified to prevent auto k8s updates #1630

Merged
merged 2 commits into from
Jan 31, 2023

Conversation

iameskild
Copy link
Member

@iameskild iameskild commented Jan 31, 2023

Reference Issues or PRs

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

I created a new Nebari cluster to test that this would work as expected. I also upgraded an existing cluster to validate that it would work for those clusters as well. No issues detected. Node pools may be destroyed and recreated if there are version differences. More information about release_channel can be found here and here.

Any other comments?

Copy link
Member

@pavithraes pavithraes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@iameskild iameskild merged commit b70493f into develop Jan 31, 2023
@iameskild iameskild deleted the gcp_release_channel branch January 31, 2023 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants