Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR lower dashboard launch timeout #1647

Merged

Conversation

ppwadhwa
Copy link
Contributor

@ppwadhwa ppwadhwa commented Feb 9, 2023

This PR will reduce the time it takes for a dashboard launch to timeout. It is now set to 5 minutes. There was some discussion about making this configurable, but I thought that could go in another PR, and at least lower it for now.

Reference Issues or PRs

What does this implement/fix?

Fixes #1616
Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

@iameskild iameskild added this to the Release 2023.2.1 milestone Feb 9, 2023
@iameskild
Copy link
Member

/bot run tests

Copy link
Member

@iameskild iameskild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM :)

@iameskild iameskild merged commit b7d7354 into nebari-dev:develop Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ENH] - Decrease the timeout for successfully dashboard deployment
2 participants