Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat GitHub actions before_script and after_script steps #1672

Merged
merged 4 commits into from
Mar 7, 2023

Conversation

costrouc
Copy link
Member

@costrouc costrouc commented Mar 3, 2023

Reference Issues or PRs

Closes #1671

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

This is required for Quansight's move towards oidc github-actions authentication.

@costrouc costrouc force-pushed the feat-github-actions-before-after-steps branch from 7bd734a to 28078ad Compare March 3, 2023 17:22
@costrouc costrouc force-pushed the feat-github-actions-before-after-steps branch from 47a1e02 to 252c4e1 Compare March 3, 2023 17:45
@costrouc costrouc requested a review from iameskild March 3, 2023 18:48
@costrouc costrouc changed the title Feat GitHub actions before after steps Feat GitHub actions before_script and after_script steps Mar 3, 2023
@costrouc
Copy link
Member Author

costrouc commented Mar 7, 2023

This is an important issue to merge since it is blocking fixing integration tests.

Copy link
Member

@iameskild iameskild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this helpful enhancement @costrouc!

The only change I think we might make is modifying the git add . command to be more precise. This will help us avoid having the script commit extra files (ie. credentials files).

We might want to specify git add ./.github ./stages.

Copy link
Member

@iameskild iameskild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@costrouc costrouc merged commit 59addfe into develop Mar 7, 2023
@costrouc costrouc deleted the feat-github-actions-before-after-steps branch March 7, 2023 01:09
@iameskild iameskild added this to the Release 2023.3.1 milestone Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

[ENH] - Support before_script and after_script within github-actions
2 participants